GitHub Actions: Pin versions for actions #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aittalam
reviewed
Aug 12, 2025
| @@ -13,10 +13,10 @@ jobs: | |||
|
|
|||
| steps: | |||
| - name: Check out the repository | |||
| uses: actions/checkout@v4 | |||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |||
There was a problem hiding this comment.
Why not directly pin to the corresponding tag?
(I understand the security concern, and am just suggesting the changes to avoid you waste time on rewriting the code... but if you prefer to keep it as-is that's also fine with me. The comment helps to understand what version we are dealing with, so the only con is maintenance but we can deal with that!)
Suggested change
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |
| uses: actions/[email protected] |
aittalam
reviewed
Aug 12, 2025
|
|
||
| - name: Install the latest version of uv and set the python version to 3.13 | ||
| uses: astral-sh/setup-uv@v6 | ||
| uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3 |
There was a problem hiding this comment.
Suggested change
| uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3 | |
| uses: astral-sh/[email protected] |
aittalam
reviewed
Aug 12, 2025
| @@ -14,12 +14,12 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Check out the repository | |||
| uses: actions/checkout@v4 | |||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |||
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |
| uses: actions/[email protected] |
aittalam
reviewed
Aug 12, 2025
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0 |
There was a problem hiding this comment.
Suggested change
| uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0 | |
| uses: actions/[email protected] |
aittalam
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.