feat: add support for tracking nightly release metadata#1972
Conversation
bhearsum
force-pushed
the
feat-add-endpoint-for-querying
branch
from
49d30d7 to
30a9db2
Compare
bhearsum
force-pushed
the
feat-add-endpoint-for-querying
branch
from
30a9db2 to
3a73672
Compare
bhearsum
force-pushed
the
feat-add-endpoint-for-querying
branch
2 times, most recently
from
3edd17e to
322a2ab
Compare
|
|
||
| class NightlyRelease(db.Model): | ||
| __tablename__ = "shipit_api_nightly_releases" | ||
| id = sa.Column(sa.Integer, primary_key=True) |
There was a problem hiding this comment.
nit: it's harmless, but not sure we need this id for anything?
There was a problem hiding this comment.
To be honest, I was mostly following the style here: a separate id as the PK like with the other tables.
bhearsum
force-pushed
the
feat-add-endpoint-for-querying
branch
from
322a2ab to
71914fd
Compare
bhearsum
force-pushed
the
feat-add-endpoint-for-querying
branch
from
71914fd to
7d5bbe2
Compare
| /nightly-release: | ||
| get: | ||
| summary: List nightly releases | ||
| operationId: shipit_api.public.api.list_nightly_releases |
There was a problem hiding this comment.
Is referencing shipit_api.public from backend_common OK? (I guess so, there's references to it from the admin api.yml already, it just surprised me a bit)
There was a problem hiding this comment.
There's no technical reason...although I can see why it's surprising and maybe confusing. I guess the alternatives here are duplication of the GET endpoint or moving the handler into backend_common. The latter would be worse IMO. The former might be okay at the risk of future diversion. (I'm inclined to just leave this as is for now.)
bhearsum
force-pushed
the
feat-add-endpoint-for-querying
branch
from
7d5bbe2 to
6208a79
Compare
2 participants
As part of https://bugzilla.mozilla.org/show_bug.cgi?id=2031045 I need a way to cheaply find the first version a locale shipped with. The solution I'm aiming at is making this data available in product-details. We already gather enough data as part of rebuilding it to make this data available for releases. We don't have it for nightlies. Let's put this data into Ship It, similar to how we're already tracking current nightly version information. After this is landed we'll need to do a backfill of Nightly data by hand, and update it in automation (similar to how we add current nightly version information) before we can start putting this data in product details.
In theory, we could gather it by looking through VCS data or scraping archive -- in practice there's far too many nightlies for this to be practical (1,000s, if not 10,000s).
See also: https://bugzilla.mozilla.org/show_bug.cgi?id=2042596