Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCO-3405] feat: Support replicas for the redis adapter #865

Merged
merged 3 commits into from
Mar 28, 2025
Merged

Conversation

ncloudioj
Copy link
Contributor

@ncloudioj ncloudioj commented Mar 26, 2025

References

JIRA: DISCO-3405

Description

This allows Merino to connect to the replica endpoint of our Redis server to handle all the read workloads so that the primary node only needs to handle write workloads and replication related tasks.

This requires a new envvar for Merino for the replica endpoint. PR filed here.

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

@ncloudioj ncloudioj requested a review from a team March 26, 2025 23:14
@ncloudioj
Copy link
Contributor Author

Thanks for the review! The cloudops-infra PR has been merged. Let's give this a spin.

@ncloudioj ncloudioj added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit 4b00a3c Mar 28, 2025
11 checks passed
@ncloudioj ncloudioj deleted the disco-3405 branch March 28, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants