drop support for AMO_ESCALATE and forwarded jobs #23338
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15542
Description
Deletes a big chunk of now unused code
This PR should not be merged until https://sql.telemetry.mozilla.org/queries/107270 is empty, or we are confident will be empty before the deploy to production.
Context
Legal escalations still escalate by creating a new job (because Cinder doesn't allow queue moves via the API currently). But we only needed all the foreign keys and NHRs when the job was shown in the reviewer tools., so it significantly simplifies the code.
Testing
No specific testing is needed as it's removing code, but you could re-test the legal escalation functionality, as there is a slight refactoring around that, and there was some shared code .
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.