Skip to content

drop support for AMO_ESCALATE and forwarded jobs #23338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eviljeff
Copy link
Member

@eviljeff eviljeff commented Apr 16, 2025

Fixes: mozilla/addons#15542

Description

Deletes a big chunk of now unused code

This PR should not be merged until https://sql.telemetry.mozilla.org/queries/107270 is empty, or we are confident will be empty before the deploy to production.

Context

Legal escalations still escalate by creating a new job (because Cinder doesn't allow queue moves via the API currently). But we only needed all the foreign keys and NHRs when the job was shown in the reviewer tools., so it significantly simplifies the code.

Testing

No specific testing is needed as it's removing code, but you could re-test the legal escalation functionality, as there is a slight refactoring around that, and there was some shared code .

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff force-pushed the 15542-drop-support-for-amo-escalate-enforcement-action branch from aab6ee2 to 790fb00 Compare April 16, 2025 16:55
@eviljeff eviljeff marked this pull request as ready for review April 17, 2025 10:29
@eviljeff eviljeff requested review from a team and diox and removed request for a team April 17, 2025 10:41
@eviljeff
Copy link
Member Author

merge blocked on mozilla/addons#15574 (if we do, then when those jobs are closed the associated NHR won't be closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove support for AMO_ESCALATE action
2 participants