Bug 2006638 - Add use_cache param to get_access_token#7131
Merged
Conversation
Contributor
Author
|
If this seems good, then I can update firefox-android and firefox-ios to support this flag. This is a breaking change for ios, but not android because it doesn't use the |
bendk
force-pushed
the
push-uksxpsosptwr
branch
from
7562c93 to
e908aea
Compare
mhammond
approved these changes
Dec 18, 2025
| /// | ||
| /// * `scopes` - Space-separated list of requested scopes. | ||
| /// * `ttl` - the ttl in seconds of the token requested from the server. | ||
| /// * `use_cache` - optionally set to false to force a new token request. |
Member
There was a problem hiding this comment.
maybe note that the returned token is cached even when use_cache = false? (if you do, I guess in the udl and other places this is copied too?)
bendk
force-pushed
the
push-uksxpsosptwr
branch
3 times, most recently
from
53b3185 to
d89ed7d
Compare
7 tasks
bendk
force-pushed
the
push-uksxpsosptwr
branch
from
d89ed7d to
6b2cfeb
Compare
Removed the `ttl` param, since multiple optional positional args can get weird. I took a look at searchfox and firefox-ios and there didn't seem to be any consumers using the `ttl` param. Alternatively, we could input an `options` struct with multiple optional params. I didn't go this way because I didn't see anyone actually setting the `ttl` param, but maybe I'm missing something.
bendk
force-pushed
the
push-uksxpsosptwr
branch
from
6b2cfeb to
65ae755
Compare
issammani
pushed a commit
to bendk/firefox-ios
that referenced
this pull request
Jan 9, 2026
Updated the code to handle the upstream change from app-services: mozilla/application-services#7131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the
ttlparam, since multiple optional positional args can get weird. I took a look at searchfox and firefox-ios and there didn't seem to be any consumers using thettlparam.Alternatively, we could input an
optionsstruct with multiple optional params. I didn't go this way because I didn't see anyone actually setting thettlparam, but maybe I'm missing something.Pull Request checklist
[ci full]to the PR title.