WIP: fix logins breach alert data being updated during login update#7147
Conversation
2570e27 to
a27f0af
Compare
bendk
left a comment
There was a problem hiding this comment.
I was a bit confused at first, but I think I understand this now. Is the intention that these fields are only updated by breach-specific methods like record_breach? If so, that seems fine to me but it's a bit unusual. Can add documentation somewhere explaining how those fields work?
Yes, exactly. I mirrored that behaviour from Desktop, and it turned out to help in this case. I think we might want to harmonize this in the future; we could also think about putting these fields into the I have added documentation about this in the udl file. |
based on #7127
Pull Request checklist
[ci full]to the PR title.