Skip to content

WIP: fix logins breach alert data being updated during login update#7147

Merged
jo merged 1 commit into
mozilla:mainfrom
jo:fix-breach-alerts
Jan 8, 2026
Merged

WIP: fix logins breach alert data being updated during login update#7147
jo merged 1 commit into
mozilla:mainfrom
jo:fix-breach-alerts

Conversation

@jo

@jo jo commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

based on #7127

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@jo jo force-pushed the fix-breach-alerts branch 2 times, most recently from 2570e27 to a27f0af Compare January 8, 2026 10:48
@jo jo requested a review from bendk January 8, 2026 11:29

@bendk bendk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit confused at first, but I think I understand this now. Is the intention that these fields are only updated by breach-specific methods like record_breach? If so, that seems fine to me but it's a bit unusual. Can add documentation somewhere explaining how those fields work?

@jo jo force-pushed the fix-breach-alerts branch from a27f0af to 8bd957d Compare January 8, 2026 14:50
@jo

jo commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

I was a bit confused at first, but I think I understand this now. Is the intention that these fields are only updated by breach-specific methods like record_breach? If so, that seems fine to me but it's a bit unusual. Can add documentation somewhere explaining how those fields work?

Yes, exactly. I mirrored that behaviour from Desktop, and it turned out to help in this case. I think we might want to harmonize this in the future; we could also think about putting these fields into the LoginMeta, or align on specific methods to update single fields or field set (eg like update_username_password, which would also make sense imo)

I have added documentation about this in the udl file.

@jo jo enabled auto-merge January 8, 2026 14:53
@jo jo added this pull request to the merge queue Jan 8, 2026
Merged via the queue into mozilla:main with commit e7fd821 Jan 8, 2026
13 checks passed
@jo jo deleted the fix-breach-alerts branch January 8, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants