Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh: Fix footer licensing link render #15168

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Sep 17, 2024

One-line summary

Fixes empty cc href in new footer.

Significant changes and points to review

The url('foundation.licensing.website-content') needs to be passed in an updated way incl. the attribute etc., and set correctly to the variable actually used in fluent.

Issue / Bugzilla link

Fixes #15167

Testing

http://localhost:8000/en-CA/

@janbrasna janbrasna marked this pull request as ready for review September 22, 2024 16:46
@janbrasna janbrasna changed the title Update footer licensing link rendering Refresh: Fix footer licensing link render Sep 22, 2024
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@alexgibson alexgibson merged commit 2daa613 into mozilla:main Sep 23, 2024
5 checks passed
@janbrasna janbrasna deleted the fix/footer-cc-link branch September 24, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[M24] Footer link to website (CC) license empty
2 participants