-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPP-3688, MPP-3689 and MPP-3690: Phones panel, dashboard switching, and stats #553
base: main
Are you sure you want to change the base?
Conversation
back button logic
…ate-relay-add-on into MPP-3688-MPP-3689-merged
e14fa81
to
5d2eff2
Compare
Closed #552 - work will be tracked here. |
Noting here from UX sync, TODO: remove the stats footer from upgrade states |
--borderRadiusXl: 24px; | ||
--borderRadius2xl: 32px; | ||
--borderRadius3xl: 40px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): Do we need these?
min-height: 315px; | ||
max-height: 315px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): Why did this change? Just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removes the second scroll bar that appears if the height is bigger in the emails panel
|
||
.dashboard-info.forwarded-calls-texts, | ||
.dashboard-info.blocked-calls-texts { | ||
padding-left: var(--spacingLg) !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): Should we comment why we're using !important
? Do we need this or can we increase specificity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The padding there was getting overridden by .dashboard-stats-list.phones-stats li { padding-left: 0; ...
, so I added the !important
This PR is for MPP-3688 and MPP-3689
L10N: mozilla-l10n/fx-private-relay-add-on-l10n#53
New feature description
Creates a new phone panel, a tab switcher for email masks and phone masks, and a phone stats page.
Screenshot (if applicable)
MPP-3688 and MPP-3689
MPP-3690
Non-premium users or premium users with no phones plan
Premium users who have not activated their phone mask
Unavailable in country
How to test
MPP-3688
If user has an active number
If user does not have an active phone number
If user does not have phone premium
If the user is from a NON-US/CA region
MPP-3689
MPP-3690
Checklist
/frontend/src/styles/tokens.scss
).