feat(phone): Add creat methods for recovery phone lib #17979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbudhram
changed the title
vbudhram
force-pushed
the
fxa-10341
branch
2 times, most recently
from
3485ddb
to
287b482
Compare
dschom
reviewed
Nov 8, 2024
|
|
||
| import { BaseError } from '@fxa/shared/error'; | ||
|
|
||
| export class RecoveryPhoneError extends BaseError { |
dschom
reviewed
Nov 8, 2024
| }); | ||
|
|
||
| afterEach(async () => { | ||
| await db.destroy(); |
There was a problem hiding this comment.
Do we need to create and destroy the db after each test, or can we just do this once for the test suite.
dschom
reviewed
Nov 8, 2024
|
|
||
| const uidBuffer = Buffer.from(uid, 'hex'); | ||
|
|
||
| // TODO: Perform phone number validation here via https://www.twilio.com/docs/lookup/v2-api#making-a-request |
There was a problem hiding this comment.
Is there a follow up for this?
There was a problem hiding this comment.
dschom
reviewed
Nov 8, 2024
| phoneNumber: string; | ||
| createdAt: number; | ||
| lastConfirmed: number; | ||
| lookupData: string; |
There was a problem hiding this comment.
Looks like it stores information if the phone number is fradulent or active and can recieve message.
dschom
reviewed
Nov 8, 2024
| lookupData JSON, | ||
| PRIMARY KEY (uid), | ||
| INDEX idx_phoneNumber (phoneNumber), | ||
| FOREIGN KEY (uid) REFERENCES accounts(uid) ON DELETE CASCADE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-10341
Closes: https://mozilla-hub.atlassian.net/browse/FXA-10330
Checklist
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.