fix: Do not return see_also values not in the same project as whiteboard tag #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t exist in Jira for a project
* upstream/main: feature: Add step to allow auto creating of components that do not yet exist in Jira for a project (mozilla#1226)
* upstream/main: feature: Add missing steps for Firefox and Core bug reports (mozilla#1227)
* upstream/main: fix: Jira.create_component called with project_key and should be just project (mozilla#1228)
* upstream/main: fix: Pass dict to create_component instead of named parameters (mozilla#1229)
* upstream/main: fix: do not attempt to delete duplicates for bz-ffx-core and bz-ffx-firefox (mozilla#1230) fix: Update actions doc to reflect new create_components option (mozilla#1231)
Bumps the minor-patch group with 6 updates: | Package | From | To | | --- | --- | --- | | [fastapi](https://github.com/fastapi/fastapi) | `0.121.1` | `0.121.3` | | [pypandoc](https://github.com/JessicaTegner/pypandoc) | `1.16` | `1.16.2` | | [click](https://github.com/pallets/click) | `8.3.0` | `8.3.1` | | [pre-commit](https://github.com/pre-commit/pre-commit) | `4.4.0` | `4.5.0` | | [bandit](https://github.com/PyCQA/bandit) | `1.8.6` | `1.9.2` | | [ruff](https://github.com/astral-sh/ruff) | `0.14.4` | `0.14.6` | Updates `fastapi` from 0.121.1 to 0.121.3 - [Release notes](https://github.com/fastapi/fastapi/releases) - [Commits](fastapi/fastapi@0.121.1...0.121.3) Updates `pypandoc` from 1.16 to 1.16.2 - [Release notes](https://github.com/JessicaTegner/pypandoc/releases) - [Changelog](https://github.com/JessicaTegner/pypandoc/blob/master/release.md) - [Commits](JessicaTegner/pypandoc@v1.16...v1.16.2) Updates `click` from 8.3.0 to 8.3.1 - [Release notes](https://github.com/pallets/click/releases) - [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst) - [Commits](pallets/click@8.3.0...8.3.1) Updates `pre-commit` from 4.4.0 to 4.5.0 - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v4.4.0...v4.5.0) Updates `bandit` from 1.8.6 to 1.9.2 - [Release notes](https://github.com/PyCQA/bandit/releases) - [Commits](PyCQA/bandit@1.8.6...1.9.2) Updates `ruff` from 0.14.4 to 0.14.6 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.14.4...0.14.6) --- updated-dependencies: - dependency-name: fastapi dependency-version: 0.121.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-patch - dependency-name: pypandoc dependency-version: 1.16.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-patch - dependency-name: click dependency-version: 8.3.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-patch - dependency-name: pre-commit dependency-version: 4.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-patch - dependency-name: bandit dependency-version: 1.9.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-patch - dependency-name: ruff dependency-version: 0.14.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* upstream/main: Bump the minor-patch group with 2 updates (mozilla#1241) Bump the minor-patch group with 3 updates (mozilla#1236) Fix mozilla#1238 - Allow attachment.flags.id to be nullable (mozilla#1239) Adding eam team to codeowners (mozilla#1237) Bump python from 3.14.0-slim to 3.14.1-slim (mozilla#1235) Bump the minor-patch group with 3 updates (mozilla#1234) Bump actions/checkout from 5 to 6 (mozilla#1232) Bump the minor-patch group with 6 updates (mozilla#1233)
alexcottner
approved these changes
Dec 18, 2025
Contributor
alexcottner
left a comment
alexcottner
left a comment
There was a problem hiding this comment.
This will cause duplicated Jira tickets to be created. For example. if a whiteboard tag for project1 is replaced with project2.
Contributor
Author
I supposed I could a special case in for BZFFX but it feels bad to do so. If someone has a different idea I would be willing work implement it. |
Contributor
I don't have any better ideas unless the BMO plugin behavior can change. We can merge this and release next week to see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the current behavior of returning all see_also values from a bug regardless of jira project. Now if a whiteboard tag matches a set of actions in the config, and a bug is returned with a se_also value for say BZFFX and the whiteboard tag is for GENAI, the BZFFX see_also will not be returned and the actions will create a new issue in the GENAI project. Before it would skip it because the BZFFX one already existed but it not related at all.
Let me know if you think there is a possibly better solution for this. Thanks