Jdk 11 262 #1927
Draft
Jdk 11 262 #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10.0 because 1.0.0 requires jdk 17
ZZZank
reviewed
Jun 1, 2025
| systemProperty 'test262properties', System.getProperty('test262properties') | ||
| if (System.getProperty('updateTest262properties') != null) { | ||
| if (System.getenv("RHINO_TEST_JAVA_VERSION") != "11") { | ||
| if ("11".equals(System.getenv("RHINO_TEST_JAVA_VERSION"))) { |
There was a problem hiding this comment.
missing a ! here ? The new condition seems to being doing the opposite of the original one
There was a problem hiding this comment.
:-) omg
will check that tomorrow....
|
Could you show me an error message or something? The CI jobs all build on Java 11, 17, and 21, and should have caught this, so I'd like to understand why it's different for you. |
|
will work on this after my vacation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was no longer able to build with with jdk 11