Add ES2022 d flag and ES2024 v flag support to RegExp #2086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good progress and I am generally in favor of Claude helping us get our spec compliance up to date, but could you take the Claude stuff out of the PR? Thanks! |
Implements foundational support for RegExp hasIndices (d) and unicodeSets (v) flags. Changes: - Add flag constants JSREG_HASINDICES (0x40) and JSREG_UNICODESETS (0x80) - Update TokenStream to accept d and v flags in regexp literals - Add hasIndices and unicodeSets properties to RegExp.prototype - Implement flag validation (u/v mutual exclusion per ES2024 spec) - Ensure alphabetical flag ordering per ES spec - Add comprehensive test suite - Update test262.properties with new flag support What works: - Flag recognition and parsing - Properties return correct boolean values - Flag validation prevents invalid combinations - All existing tests pass (backward compatible) Not yet implemented: - Actual indices array for d flag (requires regexp engine changes) - Unicode set operations for v flag (requires parser rewrite) This provides the foundation for full implementation while maintaining compatibility with existing code. Addresses mozilla#976 (ES2022 d flag) and partially addresses mozilla#1350 (ES2024 v flag)
anivar
force-pushed
the
es2022-regexp-hasindices
branch
from
0a6fc67 to
dbf98f4
Compare
|
@gbrail I've been using AI tools to help analyze the codebase and catch up with implementation approaches and verification same. I should have been more careful with the commits and documentation. I've cleaned up the PR to focus solely on the RegExp d/v flag implementation. All the unrelated documentation files have been removed, and the commits have been squashed into a single clean commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements foundational support for RegExp d (hasIndices) and v (unicodeSets) flags.
Changes
Status
Partially addresses #976 and #1350