Replace number formatting operations #2144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the implementations of toExponential, toFixed, and toPrecision on the Number class with new implementations that use a combination of BigDecimal and the new double formatting code.
gbrail
force-pushed
the
greg-new-dtoa-5
branch
from
9a38f2b to
e771eb2
Compare
|
cool |
|
@gbrail should #254 not be closed now? Doesn't happen automatically (unless using the specific GitHub syntax for it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work on number formatting.
It is stacked on top of #2132
It replaces the Number operations:
with new implementations that use BigDecimal. It also uses the new double formatter in some cases.
The new implementations work correctly for all double values in the test data that we can find, and are faster besides.
This and the first PR also fix the very old issue #254