-
Notifications
You must be signed in to change notification settings - Fork 903
improve the Number.toLocaleString() implementation #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* if 402 is not enabled for the context, ignore the given parameters * if 402 is enabled, support string locales
|
@aardvark179 please have a look at lets discuss.... |
|
Okay. I've done an exhaustive search of our internal code, and all the uses I can find pass 0 arguments, so should be good with this change. The only bug report I can find internally is that somebody wanted to pass a locale and couldn't, so this is probably fine - especially as it's neat gated behind the 402 feature. It might be worth updating the 262 tests (I think we'd need to enable 402 mode in a context factory, remove the leading |
|
@aardvark179 ok, will go forward with this, but will be busy the next days with other stuff |
7a7b1a1 to
feffbed
Compare
feffbed to
a5a5941
Compare
fe172df to
409cb9c
Compare
409cb9c to
69d87b6
Compare
b1b049a to
04fadb3
Compare
| built-ins/undefined 0/8 (0.0%) | ||
|
|
||
| ~intl402 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you accidentally removed this directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I misclicked. I meant the one after:
language/arguments-object 183/263 (69.58%)
|
@andreabergia this is in draft because i had a hard time enabling the intl402 tests. The plan is to split this into two parts, fix only the problem with some unit tests and then create a second PR for the 262.properties handling. But you have to be a bit patient because of the workshop this week and next week i have to do a talk on a conference... |
this should at least avoid the exceptions described in #535