Skip to content

Conversation

@rbri
Copy link
Collaborator

@rbri rbri commented Nov 27, 2025

  • if 402 is not enabled for the context, ignore the given parameters
  • if 402 is enabled, support string locales

this should at least avoid the exceptions described in #535

* if 402 is not enabled for the context, ignore the given parameters
* if 402 is enabled, support string locales
@rbri rbri marked this pull request as draft November 27, 2025 15:54
@rbri
Copy link
Collaborator Author

rbri commented Nov 27, 2025

@aardvark179 please have a look at lets discuss....

@aardvark179
Copy link
Contributor

Okay. I've done an exhaustive search of our internal code, and all the uses I can find pass 0 arguments, so should be good with this change. The only bug report I can find internally is that somebody wanted to pass a locale and couldn't, so this is probably fine - especially as it's neat gated behind the 402 feature.

It might be worth updating the 262 tests (I think we'd need to enable 402 mode in a context factory, remove the leading ~ from the intl402 line in the properties file and update then update the properties. I think we maybe pass about 20 tests from that entire group, but it's a start.

@rbri
Copy link
Collaborator Author

rbri commented Nov 27, 2025

@aardvark179 ok, will go forward with this, but will be busy the next days with other stuff

@rbri rbri force-pushed the Number_toLocaleString branch from 7a7b1a1 to feffbed Compare November 27, 2025 17:49
@rbri rbri force-pushed the Number_toLocaleString branch from feffbed to a5a5941 Compare November 27, 2025 18:24
@rbri rbri force-pushed the Number_toLocaleString branch 2 times, most recently from fe172df to 409cb9c Compare November 27, 2025 20:08
@rbri rbri force-pushed the Number_toLocaleString branch from 409cb9c to 69d87b6 Compare November 28, 2025 06:11
@rbri rbri force-pushed the Number_toLocaleString branch from b1b049a to 04fadb3 Compare November 30, 2025 10:20
built-ins/undefined 0/8 (0.0%)

~intl402

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you accidentally removed this directory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I misclicked. I meant the one after:

language/arguments-object 183/263 (69.58%)

@rbri
Copy link
Collaborator Author

rbri commented Dec 1, 2025

@andreabergia this is in draft because i had a hard time enabling the intl402 tests.
The setup for this is different from the other test folders and or regenertator fails on this (adds wrong entries). Spend already some time over the weekend to understand the generator and try to fix it. But i faild more or less and then tried to reimplement the generator using a different approach but i'm not 100% done.

The plan is to split this into two parts, fix only the problem with some unit tests and then create a second PR for the 262.properties handling. But you have to be a bit patient because of the workshop this week and next week i have to do a talk on a conference...

@rbri rbri closed this Dec 8, 2025
@rbri rbri deleted the Number_toLocaleString branch December 8, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants