Implement support for destructuring in catch
#2195
Merged
+237
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the parser and IR to support things like `catch ({message})` or
`catch ([a, b])`.
Note that, while Rhino supports a non-standard extension for conditions
in catch clauses, i.e. `catch (a if b)`, I have opted to _not_ support
it if we have a destructuring expression.
Collaborator
|
Wow 50 mor passing test... |
0xe
approved these changes
Dec 4, 2025
rbri
reviewed
Dec 6, 2025
| public class CatchClause extends AstNode { | ||
|
|
||
| private Name varName; | ||
| private AstNode varName; |
Collaborator
There was a problem hiding this comment.
at least the name of the var and the name of the getter/setter does no longer match the value
rbri
reviewed
Dec 6, 2025
| catchCond = transform(ccc); | ||
| } else { | ||
| AstNode ccc = cc.getCatchCondition(); | ||
| if (ccc != null) { |
Collaborator
There was a problem hiding this comment.
depressive if - maybe you can swap the branches
rbri
approved these changes
Dec 6, 2025
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the parser and IR to support things like
catch ({message})orcatch ([a, b]).Note that, while Rhino supports a non-standard extension for conditions in catch clauses, i.e.
catch (a if b), I have opted to not support it if we have a destructuring expression.The implementation does this:
CatchClausewas made more generic, and will now contain either the name or the destructuring expressionwe generate:
Fixes #2194