polish the TypeInfo system
#2201
Open
+525
−284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it should be replaced by a more general solution like `TypeInfo.visitComponents`
Using this factory to resolve self-referencing type variables (`T extends Enum<T>`) will cause inf loop
- support formatting VariableTypeInfo to `K extends SingleBound` - cleaner overall design
ZZZank
commented
Dec 7, 2025
Comment on lines
+9
to
+18
| /// Full feature formatting context | ||
| /// | ||
| /// | Type | Full representation | Representation using this context | | ||
| /// | - | - | - | | ||
| /// | Class | java.lang.String | java.lang.String | | ||
| /// | Nested Class | Entry (in java.util.Map) | java.util.Map$Entry | | ||
| /// | Array | java.lang.String[] | java.lang.String[] | | ||
| /// | Parameterized | java.lang.List<java.lang.String> | java.util.List<java.lang.String> | | ||
| /// | Variable | T extends java.lang.String | T extends java.lang.String | | ||
| /// | [TypeInfo#NONE] | (No standard representation) | ? | |
Contributor
Author
There was a problem hiding this comment.
Check me: This Javadoc is written in Markdown style, because it's clearer than HTML table when displayed in source file, but this also makes it inconsistent with other Javadoc. Should replace it with old style Javadoc (aka table via HTML tag)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
TypeInfosystem works good enough in common use cases, but there still some rough corners / lack of design / overengineering that need to be polished.All changes are documented in commit messages. Notable changes are:
TypeInfoFactory.NO_CACHEis removed, because it's unable to handle self referencing type variables, e.g.E extends Enum<E>Outer<T1>.Innerstyle parameterized type, including correct formatting and consolidation mapping generation.TypeFormatContextis redesigned to be more consistent and easy to use.