Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zip from 0.6.6 to 2.1.3 #2227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump zip from 0.6.6 to 2.1.3 #2227

wants to merge 1 commit into from

Conversation

glandium
Copy link
Collaborator

This, unfortunately, comes with a massive performance regression: 25% ! So, PLEASE DO NOT MERGE.

Copy link
Collaborator

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf issues

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.20%. Comparing base (0cc0c62) to head (e544cad).
Report is 64 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2227       +/-   ##
===========================================
+ Coverage   30.91%   41.20%   +10.29%     
===========================================
  Files          53       53               
  Lines       20112    20472      +360     
  Branches     9755     9680       -75     
===========================================
+ Hits         6217     8436     +2219     
- Misses       7922     8048      +126     
+ Partials     5973     3988     -1985     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants