Add ability to skip comma flag even if no comma output implemented #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 359 360 +1
=====================================
+ Hits 359 360 +1
Continue to review full report at Codecov.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 359 360 +1
=========================================
+ Hits 359 360 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses half of issue #71 by adding ability to ignore a comma flag -- e.g.
#'d-- and not interpret it literally. The result is as if the comma flag is not present, e.g.#d. All existing tests work, and added a new test section for the comma flag.This pull request at least makes this implementation of
printf()compatible with existing code which uses the comma flag... At least seg faults and/or unwanted output no longer occur. Next step will be to implement the comma output with some kind of mechanism to turn it on; environment variable?