Change %p formatting to match glibc #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means prefixing with `0x` and using lowercase hex letters.
This means printing "(nil)" instead of "0".
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
3 tasks
|
Since this is non-standard, I suggest you have a preprocessor define controlling whether |
KarlK90
pushed a commit
to qmk/printf
that referenced
this pull request
Jul 7, 2022
…d and significant doxygen comment edits.
1 task
maribu
added a commit
to maribu/RIOT
that referenced
this pull request
Aug 22, 2025
newlib and picolibc already implicitly add the `0x` prefix for `%p` just as glibc does, and some of our tests scripts depend on this. (And subjectively, this looks better.) This adds mpaland/printf#90 on top of our patches.
baptleduc
pushed a commit
to baptleduc/RIOT
that referenced
this pull request
Sep 4, 2025
newlib and picolibc already implicitly add the `0x` prefix for `%p` just as glibc does, and some of our tests scripts depend on this. (And subjectively, this looks better.) This adds mpaland/printf#90 on top of our patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
%pformat is not defined by the standard, that is, it's implementation specific. However, many people are used to what glibc prints:0xto emphasize that pointers are printed as hex, and a special "(nil)" string when a null pointer is provided, and lower-case letters for hex digits.This fixes #57 and fixes #84.