Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video/out/wayland_common: fix dnd with focus follow mouse #15306

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

video/out/wayland_common: fix dnd with focus follow mouse #15306

wants to merge 3 commits into from

Commits on Nov 14, 2024

  1. video/out/wayland_common: extract data offer to a struct 

    The data offers can be either dnd or selection offers.
Add a separate struct for it so that handling of selection
offers can be added.
    @na-na-hi
    na-na-hi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0db5462 View commit details
    Browse the repository at this point in the history

  2. video/out/wayland_common: fix dnd with focus follow mouse 

    Whenever mpv window gains focus, a new data offer is sent for the
selection. However, mpv currently treats it the same as dnd data
offers, which results in wrong handling. One bug which results from
this is when focus follow mouse is enabled, dropping the dnd file
results in the window being focused and selection offer being sent,
freeing the existing dnd offer. This results in dnd being broken
on at least GTK3.

Fix this by separating selection and dnd offer handling. Since there
is no way to know whether an offer introduced by
data_device_handle_data_offer is a selection or dnd offer, make it
pending, and move them once the identity is confirmed.
    @na-na-hi
    na-na-hi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5759f8a View commit details
    Browse the repository at this point in the history

  3. video/out/wayland_common: initialize offer fd

    @na-na-hi
    na-na-hi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3fda7c8 View commit details
    Browse the repository at this point in the history