fix(schema): Do not dot-expand terminal paths #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
Problem
When using configuration like:
{ "yaml.schemas": { "./some/relative/schema.json": "relpath/*" } }The
Settings.expand()function was incorrectly expanding the dots in the file path"./some/relative/schema.json", resulting in:{ yaml = { schemas = { ["/"] = { ["some/relative/schema"] = { json = "relpath/*" } } } } }Root Cause
The
Settings.expand()function recursively expands all dotted keys in all nested tables. However, this is incorrect for properties likeyaml.schemaswhich have:type: "object"in their JSON schemapropertiesfield (indicating a free-form dictionary)These "terminal objects" have user-defined keys (like file paths, URLs) that should NOT be treated as nested property paths.
We fix this by generating a lookup table of "terminal object" key paths at build time. Then, when dot-expanding, we stop expanding if the key path is terminal.