Re:#926, Fix #925 Memory Leak while WebSocketServerHandshakeException… #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…akeException or Channel failed
|
@mrniko Please see if we merge this patch. |
|
Thanks for contribution! |
|
I'm not sure, but I feel that always removing the client from uuid2client is wrong. if the handshake fails on reconnection (with a sid) due to a recoverable cause (I'm thinking that maybe the writeFlush failed becaouse of reasons) this fix removes any chance for recovery wouldn't it be valuable to check, for instance, if it had time to add namespaces before closing it? made a tentative pr with the fix #992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… or Channel failed