feat: TS + Lint in CI (#77)

* feat: TS + Lint in CI * fix * feat: Lint CI * Update lint-typescript.yml * Update lint-typescript.yml * Update package.json
mrousavy · Aug 28, 2024 · a0e2fea · a0e2fea
1 parent 254967a
commit a0e2fea
Show file tree

Hide file tree

Showing 7 changed files with 95 additions and 0 deletions.
diff --git a/.github/workflows/lint-typescript.yml b/.github/workflows/lint-typescript.yml
@@ -0,0 +1,88 @@
+name: Lint TypeScript
+
+permissions:
+  checks: write
+  contents: read
+  pull-requests: read
+
+on:
+  push:
+    branches:
+      - main
+    paths:
+      - '.github/workflows/lint-typescript.yml'
+      - '**/*.ts'
+      - '**/*.tsx'
+      - '**/*.js'
+      - '**/*.jsx'
+      - '**/*.json'
+      - '**/*.lockb'
+      - '**/package.json'
+  pull_request:
+    paths:
+      - '.github/workflows/lint-typescript.yml'
+      - '**/*.ts'
+      - '**/*.tsx'
+      - '**/*.js'
+      - '**/*.jsx'
+      - '**/*.json'
+      - '**/*.lockb'
+      - '**/package.json'
+
+jobs:
+  tsc:
+    name: Compile TypeScript (tsc)
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: oven-sh/setup-bun@v1
+      - uses: reviewdog/action-setup@v1
+
+      - name: Install npm dependencies (bun)
+        run: bun install
+
+      - name: Run TypeScript (tsc)
+        run: |
+          bun typescript | reviewdog -name="tsc" -efm="%f(%l,%c): error TS%n: %m" -reporter="github-pr-review" -filter-mode="nofilter" -fail-on-error -tee
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+  lint:
+    name: Lint TypeScript (eslint, prettier)
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: oven-sh/setup-bun@v1
+      - uses: reviewdog/action-setup@v1
+
+      - name: Install npm dependencies (bun)
+        run: bun install
+
+      - name: Run ESLint CI in example/
+        working-directory: example
+        run: bun lint-ci
+      - name: Run ESLint CI in packages/nitrogen
+        working-directory: packages/nitrogen
+        run: bun lint-ci
+      - name: Run ESLint CI in packages/react-native-nitro-image
+        working-directory: packages/react-native-nitro-image
+        run: bun lint-ci
+      - name: Run ESLint CI in packages/react-native-nitro-modules
+        working-directory: packages/react-native-nitro-modules
+        run: bun lint-ci
+
+      - name: Run ESLint with auto-fix in example/
+        working-directory: example
+        run: bun lint
+      - name: Run ESLint with auto-fix in packages/nitrogen
+        working-directory: packages/nitrogen
+        run: bun lint
+      - name: Run ESLint with auto-fix in packages/react-native-nitro-image
+        working-directory: packages/react-native-nitro-image
+        run: bun lint
+      - name: Run ESLint with auto-fix in packages/react-native-nitro-modules
+        working-directory: packages/react-native-nitro-modules
+        run: bun lint
+
+      - name: Verify no files have changed after auto-fix
+        run: git diff --exit-code HEAD
diff --git a/bun.lockb b/bun.lockb
diff --git a/example/package.json b/example/package.json
@@ -6,7 +6,9 @@
     "android": "react-native run-android",
     "ios": "react-native run-ios",
     "clean": "del-cli android/build node_modules/**/android/build lib",
+    "typescript": "tsc --noEmit false",
     "lint": "eslint \"**/*.{js,ts,tsx}\" --fix",
+    "lint-ci": "eslint \"**/*.{js,ts,tsx}\" -f @jamesacarr/github-actions",
     "start": "react-native start",
     "pods": "cd ios && pod install && rm -rf .xcode.env.local",
     "build:android": "cd android && ./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a",

diff --git a/package.json b/package.json
@@ -10,6 +10,7 @@
     "bootstrap": "bun --filter=\"**\" install && bun tsc && bun --filter=\"react-native-nitro-example\" pods",
     "typescript": "bun --filter=\"**\" typescript",
     "lint": "bun --filter=\"**\" lint",
+    "lint-fix": "bun --filter=\"**\" lint --fix",
     "release": "release-it",
     "clean": "rm -rf packages/**/tsconfig.tsbuildinfo packages/**/node_modules packages/**/lib"
   },
@@ -22,6 +23,7 @@
   "devDependencies": {
     "@release-it/conventional-changelog": "^8.0.1",
     "@release-it/bumper": "^6.0.1",
+    "@jamesacarr/eslint-formatter-github-actions": "^0.2.0",
     "release-it": "^17.6.0"
   },
   "release-it": {

diff --git a/packages/nitrogen/package.json b/packages/nitrogen/package.json
@@ -17,6 +17,7 @@
     "postinstall": "tsc || exit 0;",
     "typecheck": "tsc --noEmit",
     "lint": "eslint \"**/*.{js,ts,tsx}\" --fix",
+    "lint-ci": "eslint \"**/*.{js,ts,tsx}\" -f @jamesacarr/github-actions",
     "release": "tsc && release-it",
     "typescript": "tsc --noEmit false"
   },

diff --git a/packages/react-native-nitro-image/package.json b/packages/react-native-nitro-image/package.json
@@ -30,6 +30,7 @@
     "typecheck": "tsc --noEmit",
     "clean": "del-cli android/build node_modules/**/android/build lib",
     "lint": "eslint \"**/*.{js,ts,tsx}\" --fix",
+    "lint-ci": "eslint \"**/*.{js,ts,tsx}\" -f @jamesacarr/github-actions",
     "typescript": "tsc --noEmit false",
     "specs": "bun run --filter=\"**\" typescript && bun nitro-codegen --logLevel=\"debug\""
   },

diff --git a/packages/react-native-nitro-modules/package.json b/packages/react-native-nitro-modules/package.json
@@ -28,6 +28,7 @@
     "typecheck": "tsc --noEmit",
     "clean": "del-cli android/build node_modules/**/android/build lib",
     "lint": "eslint \"**/*.{js,ts,tsx}\" --fix",
+    "lint-ci": "eslint \"**/*.{js,ts,tsx}\" -f @jamesacarr/github-actions",
     "release": "bob build && release-it",
     "typescript": "tsc --noEmit false"
   },