Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adjust Pod/Gradle message #288

Merged
merged 2 commits into from
Nov 5, 2024
Merged

chore: Adjust Pod/Gradle message #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fafbbb3
chore: Rename Pod/Gradle message
mrousavy Nov 5, 2024
7136a12
chore: Put flame infront
mrousavy Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/BUILD_ERROR.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ body:

> Configure project :react-native-nitro-modules

[NitroModules] Your app is boosted by nitro modules! 🔥
[NitroModules] 🔥 Your app is boosted by nitro modules!

...
validations:
Expand Down
2 changes: 2 additions & 0 deletions packages/nitrogen/src/autolinking/android/createGradleExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ ${createFileMetadataString(`${name}+autolinking.gradle`)}
/// apply from: '../nitrogen/generated/android/${name}+autolinking.gradle'
/// \`\`\`

logger.warn("[NitroModules] 🔥 ${name} is boosted by nitro!")

android {
sourceSets {
main {
Expand Down
2 changes: 1 addition & 1 deletion packages/nitrogen/src/autolinking/ios/createPodspecRubyExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ ${createFileMetadataString(`${name}+autolinking.rb`, '#')}
# \`\`\`

def add_nitrogen_files(spec)
Pod::UI.puts "[NitroModules] Adding ${name} specs..."
Pod::UI.puts "[NitroModules] 🔥 ${name} is boosted by nitro!"

spec.dependency "NitroModules"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native-nitro-image/nitrogen/generated/android/NitroImage+autolinking.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
/// apply from: '../nitrogen/generated/android/NitroImage+autolinking.gradle'
/// ```

logger.warn("[NitroModules] 🔥 NitroImage is boosted by nitro!")

android {
sourceSets {
main {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-image/nitrogen/generated/ios/NitroImage+autolinking.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# ```

def add_nitrogen_files(spec)
Pod::UI.puts "[NitroModules] Adding NitroImage specs..."
Pod::UI.puts "[NitroModules] 🔥 NitroImage is boosted by nitro!"

spec.dependency "NitroModules"

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-modules/NitroModules.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ require "json"

package = JSON.parse(File.read(File.join(__dir__, "package.json")))

Pod::UI.puts "[NitroModules] Your app is boosted by nitro modules! 🔥"
Pod::UI.puts "[NitroModules] 🔥 Your app is boosted by nitro modules!"

Pod::Spec.new do |s|
s.name = "NitroModules"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-modules/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def getExtOrIntegerDefault(name) {
return rootProject.ext.has(name) ? rootProject.ext.get(name) : (project.properties["Nitro_" + name]).toInteger()
}

logger.warn("[NitroModules] Your app is boosted by nitro modules! 🔥")
logger.warn("[NitroModules] 🔥 Your app is boosted by nitro modules!")

android {
namespace "com.margelo.nitro"
Expand Down
Loading