refactor(devops): extract get_primary_ip() to DRY ip-route-get pattern (#2825)#2932
Closed
mrveiss wants to merge 1 commit intoDev_new_guifrom
Closed
refactor(devops): extract get_primary_ip() to DRY ip-route-get pattern (#2825)#2932mrveiss wants to merge 1 commit intoDev_new_guifrom
mrveiss wants to merge 1 commit intoDev_new_guifrom
Conversation
#2825) Three inline ip-route-get invocations in install.sh consolidated into a single get_primary_ip() helper. All call sites use OVERRIDE_IP fallback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
| Metric | Count |
|---|---|
| Total Violations | 4 |
| SSOT Violations (high priority) | 3 |
| Other Violations | 1 |
⚠️ 3 values have SSOT config equivalents!
These should be replaced with SSOT config imports:
Python:
from src.config.ssot_config import config
# Use: config.vm.main, config.port.backend, config.backend_urlTypeScript:
import config from '@/config/ssot-config'
// Use: config.vm.main, config.port.backend, config.backendUrl📖 See SSOT_CONFIG_GUIDE.md for documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_primary_ip()shell function from 3 inline invocations ininstall.sh${OVERRIDE_IP:-$(get_primary_ip)}Closes #2825
🤖 Generated with Claude Code