fix(infra): replace hardcoded IPs in utility scripts with env var overrides (#3051)#3065
Closed
mrveiss wants to merge 1 commit intoDev_new_guifrom
Closed
fix(infra): replace hardcoded IPs in utility scripts with env var overrides (#3051)#3065mrveiss wants to merge 1 commit intoDev_new_guifrom
mrveiss wants to merge 1 commit intoDev_new_guifrom
Conversation
…rrides (#3051) 3 files updated to use AUTOBOT_FRONTEND_URL, AUTOBOT_BROWSER_HOST, AUTOBOT_BROWSER_PORT env vars with 127.0.0.1 safe defaults: - test_console_using_browser_vm.js: 3 IPs replaced - capture_console_logs.js: 1 IP replaced - playwright-server.js: 4 IPs replaced Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
Duplicate — already merged in PR #3062 |
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.env.*with fallback pattern to infrastructure utility/test scripts172.16.168.*IPs with configurable env var constantstest-validation-comprehensive-fixed.jspatternFiles changed:
autobot-infrastructure/shared/scripts/utilities/test_console_using_browser_vm.jsautobot-infrastructure/shared/scripts/utilities/capture_console_logs.jsautobot-infrastructure/shared/scripts/infrastructure/playwright-server.jsCloses #3051
Test plan
FRONTEND_URL=http://10.0.0.1:5173override works for each scriptBROWSER_VM_HOSToverride works for browser VM scripts🤖 Generated with Claude Code