fix(tts): call _check_cache_writable before pocket_tts import (#3480)

[mrveiss]

Summary

Moves _check_cache_writable(MODELS_DIR) to execute before from pocket_tts import TTSModel in _load_model(). Since pocket_tts or its dependencies may perform HuggingFace Hub cache I/O at import time, checking writability first ensures we get a clear diagnostic error rather than a misleading "accept terms / hf auth login" message.

Also removes the redundant MODELS_DIR.mkdir(parents=True, exist_ok=True) call that followed the check, since _check_cache_writable already calls mkdir internally (added in #3471). VOICES_DIR.mkdir() is unchanged.

Changes

• Reorder: _check_cache_writable(MODELS_DIR) moved before from pocket_tts import TTSModel
• Remove: redundant MODELS_DIR.mkdir(parents=True, exist_ok=True) after the check

Related

• Closes fix(tts): _check_cache_writable called after pocket_tts import — should precede it #3480
• Related: bug(tts): voice cloning shows misleading 'accept terms / hf auth login' error when real cause is file permission denied #3466, bug(tts): _check_cache_writable only checks root MODELS_DIR, not hub/xet subdirs where pocket_tts actually fails #3471

🤖 Generated with Claude Code

[github-actions]

✅ SSOT Configuration Compliance: Passing

🎉 No hardcoded values detected that have SSOT config equivalents!

[mrveiss]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}