Skip to content

fix(frontend): remove as-any cast and duplicate KnowledgeRepository in KBSearchResultPanel (#3940)#3958

Merged
mrveiss merged 2 commits intoDev_new_guifrom
fix/issue-3940
Apr 8, 2026
Merged

fix(frontend): remove as-any cast and duplicate KnowledgeRepository in KBSearchResultPanel (#3940)#3958
mrveiss merged 2 commits intoDev_new_guifrom
fix/issue-3940

Conversation

@mrveiss
Copy link
Copy Markdown
Owner

@mrveiss mrveiss commented Apr 8, 2026

Closes #3940

  • Added repository prop to receive KnowledgeRepository from parent
  • Removed duplicate new KnowledgeRepository() instantiation
  • Removed unsafe as-any cast, properly typed full.content
  • Proper dependency injection pattern instead of creating duplicate instance

mrveiss and others added 2 commits April 8, 2026 10:10
…n KBSearchResultPanel (#3940)

- Added repository prop to receive KnowledgeRepository from parent
- Removed new KnowledgeRepository() instantiation
- Removed as-any cast, properly typed full.content
- Proper dependency injection instead of duplicating instance

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Resolved conflict in KBSearchResultPanel.vue: use optional chaining full?.content
for safe null handling while keeping the repository prop injection fix.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mrveiss mrveiss merged commit c283192 into Dev_new_gui Apr 8, 2026
1 check failed
@mrveiss mrveiss deleted the fix/issue-3940 branch April 8, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant