test(ci): run audit-unwired-trackers tests before cron audit (#6929)#7873
Merged
Conversation
Wire the 76-test suite in pipeline-scripts/test_audit_unwired_trackers.py into the unwired-tracker-audit workflow so a regression in the regex, scan, or dedup paths breaks CI before the audit step runs. Addresses the Tier-3 dogfooding gap identified in #6929: the audit script had 387 LOC and zero automated tests. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Contributor
|
| Metric | Count |
|---|---|
| Total Violations | 7 |
| SSOT Violations (high priority) | 7 |
| Other Violations | 0 |
⚠️ 7 values have SSOT config equivalents!
These should be replaced with SSOT config imports:
Python:
from src.config.ssot_config import config
# Use: config.vm.main, config.port.backend, config.backend_urlTypeScript:
import config from '@/config/ssot-config'
// Use: config.vm.main, config.port.backend, config.backendUrl📖 See SSOT_CONFIG_GUIDE.md for documentation.
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytest pipeline-scripts/test_audit_unwired_trackers.pystep to.github/workflows/unwired-tracker-audit.yml, running before the audit stepis_test_path, scan boundaries, dedup, and end-to-end fixturesProblem solved
pipeline-scripts/audit_unwired_trackers.pyis the Tier-3 cron defense for the #6836 closure-gate process. It had 387 LOC and zero automated tests. Silent regressions in the regex, scan, or dedup paths would surface as "no findings" rather than a clear test failure.Acceptance criteria
Test plan
pytest pipeline-scripts/test_audit_unwired_trackers.py: 76 passed ✅🤖 Generated with Claude Code