Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: Add workflows/ubuntu.yml and macos #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jarod42
Copy link

@Jarod42 Jarod42 commented Nov 1, 2024

  • OBCD build fails, so disabled
  • I didn't find right package for TDS, so disabled

@Jarod42 Jarod42 changed the title [CI]: Add workflows/ubuntu.yml [CI]: Add workflows/ubuntu.yml and macos Nov 1, 2024
@mtangoo
Copy link
Owner

mtangoo commented Nov 3, 2024

Hi Jarod,
Thanks for interest in contributing. it is welcome!

  • can you share why ODBC build failed? May be I can help make it build?
  • There is FreeTDS, Please have a look at it

@Jarod42
Copy link
Author

Jarod42 commented Nov 3, 2024

Hi Jarod,
Thanks for interest in contributing. it is welcome!

Mostly to upgrade dependencies of Codelite which uses embed old WxDatabaseLayer that I want to change to submodule.
Happy there is someone to handle incoming PRs :-)

can you share why ODBC build failed? May be I can help make it build?

From failing build

[ 46%] Building CXX object CMakeFiles/wxdatabase.dir/src/database/mysql/mysql_resultset_metadata.cpp.o
In file included from /home/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_resultset_metadata.cpp:5:
/usr/include/mariadb/mysql_com.h:3:2: warning: #warning This file should not be included by clients, include only <mysql.h> [-Wcpp]
    3 | #warning This file should not be included by clients, include only <mysql.h>
      |  ^~~~~~~

warning to fix

[ 56%] Building CXX object CMakeFiles/wxdatabase.dir/src/database/odbc/odbc_preparedstatement.cpp.o
/home/runner/work/wxDatabase/wxDatabase/src/database/odbc/odbc_param.cpp: In member function ‘SQLLEN* wxOdbcParameter::GetParameterLengthPtr()’:
/home/runner/work/wxDatabase/wxDatabase/src/database/odbc/odbc_param.cpp:255:10: error: invalid conversion from ‘long long int*’ to ‘SQLLEN*’ {aka ‘long int*’} [-fpermissive]
  255 |   return &m_nBufferLength;
      |          ^~~~~~~~~~~~~~~~
      |          |
      |          long long int*

Type mismatch

It seems easy to fix, but not familiar enough to fix it in portable way across all odbc types.

Primary goal of this PR is to add CI.
Other ones would come normally :)

There is FreeTDS, Please have a look at it

It seems it is not installable via apt-get and requires self build :-/
It might be added after IMO.

@mtangoo
Copy link
Owner

mtangoo commented Nov 3, 2024

Great then. Can you open new issue with details for the build failure? Include version of Mysql/mariadb version that you have installed

I wi review and merge this one. But would be glad to fix the other issue too

@Jarod42
Copy link
Author

Jarod42 commented Nov 3, 2024

#30 and #31 created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants