Skip to content

Commit

Permalink
make boot.sh run as process 0
Browse files Browse the repository at this point in the history
we want boot.sh to correctly receive and forwards signals. this commit removes
the double indirection (`CMD` in non array form will already execute the command
in a sh subshell and we wrapped our script in another one).
  • Loading branch information
nvdk committed Jul 10, 2023
1 parent 6f49345 commit d23754a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ RUN chmod +x /usr/src/app/build-production.sh

EXPOSE ${PORT}

CMD sh boot.sh
CMD ["/usr/src/app/boot.sh"]

# This stuff only runs when building an image from the template
ONBUILD RUN rm -Rf /app/scripts
Expand Down
1 change: 1 addition & 0 deletions boot.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/usr/bin/env bash
if [ "$NODE_ENV" == "development" ]
then
# Run live-reload development
Expand Down

0 comments on commit d23754a

Please sign in to comment.