Conversation
Signed-off-by: hendrixx-cnc <tjhendrx@icloud.com>
Collaborator
|
@mudler code review looks good at e4315c8. This removes exactly the two stray additional_information tokens still present on latest master: one makes the numeric literal invalid, and the other would raise NameError at module import. No other test behavior changes. The patch applies cleanly to master 8b01583 and git diff --check passes. DCO passes. I could not run Python parsing or the backend suite here because this environment has no Python interpreter; no substantive CI results are available yet. Good to merge from the code-review side, with runtime validation still pending. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a
SyntaxError: invalid decimal literalinbackend/python/vllm-omni/test.py.A stray string fragment (
additional_information) was concatenated withseed=42on line 71 (seed=42additional_information) and placed as an isolated identifier on line 81, preventing the test module from being parsed or executed by Python interpreters.Changes
seed=42additional_informationtoseed=42inGenerateImageRequestadditional_informationtoken aboveif __name__ == "__main__":