fix(gallery): set MiniCPM5 context at the top level - #12163
Open
localai-org-maint-bot wants to merge 1 commit into
Open
localai-org-maint-bot wants to merge 1 commit into
localai-org-maint-bot wants to merge 1 commit into
Conversation
The Q4 and Q8 overrides place context_size inside parameters, where PredictionOptions ignores it. Move it beside parameters so both builds use the intended 8,192-token context, matching F16. Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the default context for the MiniCPM5-2B Q4_K_M and Q8_0 gallery entries. Both entries put
context_sizeinsideparameters, whereschema.PredictionOptionssilently ignores it. Move it tooverrides.context_sizesoconfig.ModelConfigloads the intended 8,192 tokens, matching the F16 variant. Update the gallery documentation.Notes for Reviewers
Validation:
config.ModelConfig: Q4 and Q8 had nilContextSizebefore the fix; all three builds now load 8192.go test ./core/gallery -run TestGallery -ginkgo.focus='gallery/index.yaml|gallery variant lint helpers' -count=1passes.x-linked-etagheaders at publisher revision2079a22f3beaa4e306449978533478fe0522f4b3. Weight URLs and hashes are unchanged.This cron checked open gallery PRs and current HF trending models first. Existing green PRs were left untouched.
Signed commits