Fixed an Issue Regarding PHP Version Requirements In The Installer #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added php version to php-redis package to prevent it from installing as 8.3 and pulling in 8.3 php dependencies. Also Updated uninstaller to handle Raspbian Bullseye with regards to versioning the php package it is removing.
Corrected minor issue with if statement syntax
|
Ill review this and get merged in asap.
Eric Davisson
Developer
Mudpi <https://mudpi.app>
God Bless
…On Mon, Feb 17, 2025 at 1:32 PM Daniel434 ***@***.***> wrote:
It seems that one of the PHP packages didn't specify a version in the
install script. I updated this to follow the same version of PHP that the
other PHP dependencies are being installed with.
Also noticed that there wasn't any handling for Rasbian 11 in the
uninstall script. I updated this as well since this is the version I am
using.
Tested this by running an install using a local copy of the install script
on a Desktop running Rasbian 11 using the force-yes option and the install
succeeded without intervention. Also ran the uninstall script and observed
the environment being detected and the defined PHP package being removed.
------------------------------
You can view, comment on, or merge this pull request online at:
#15
Commit Summary
- 6b136e6
<6b136e6>
Update PHP version logic in install and uninstall scripts
- aecdca6
<aecdca6>
Update PHP version logic in install and uninstall scripts
File Changes
(2 files <https://github.com/mudpi/installer/pull/15/files>)
- *M* install.sh
<https://github.com/mudpi/installer/pull/15/files#diff-043df5bdbf6639d7a77e1d44c5226fd7371e5259a1e4df3a0dd5d64c30dca44f>
(6)
- *M* uninstall.sh
<https://github.com/mudpi/installer/pull/15/files#diff-794e65e0ee6053d90c158cf942f93caee8a9fb1473830f1ccd660cf865c90828>
(5)
Patch Links:
- https://github.com/mudpi/installer/pull/15.patch
- https://github.com/mudpi/installer/pull/15.diff
—
Reply to this email directly, view it on GitHub
<#15>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADNTLKM7OZHJ66MRV4MCCXD2QI2LBAVCNFSM6AAAAABXKBBVO6VHI2DSMVQWIX3LMV43ASLTON2WKOZSHA2TQNRVGE4DSNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that one of the PHP packages didn't specify a version in the install script. I updated this to follow the same version of PHP that the other PHP dependencies are being installed with.
Also noticed that there wasn't any handling for Rasbian 11 in the uninstall script. I updated this as well since this is the version I am using.
Tested this by running an install using a local copy of the install script on a Desktop running Rasbian 11 using the force-yes option and the install succeeded without intervention. Also ran the uninstall script and observed the environment being detected and the defined PHP package being removed.