-
Notifications
You must be signed in to change notification settings - Fork 30
Add SNI, NOISE, CERTHASH, WEBRTC, WEBRTC-DIRECT in py-multiaddr #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
"/ip4/127.0.0.1/p2p/QmcgpsyWgH8Y8ajJz1Cu72KnS5uo2Aa2LpzU7kinSupNKC/tcp/1234/unix/stdio", | ||
"/dns/example.com", | ||
"/dns4/موقع.وزارة-الاتصالات.مصر", | ||
"/ip4/127.0.0.1/tcp/443/tls/sni/example.com/http/http-path/foo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added a test case for sni
multiaddr as given in go-multiaddr tests
@acul71: Can you please take a look why these checks are failing with my changes, I am not understanding. |
- Added the protocol utils in certhash.py - Added the internal logic test suite in test_protocols.py - Added the certhash multiaddr test cases in test_multiaddr.py
Added the certhash protcol, along with the test-suite |
- Added the protocols in the registry in protcols.py - Added the maddr test cases in test_multiaddr.py
Added webrtc and webrtc-direct in 4507543, along with maddr test cases in test_multiaddr.py |
Tracks: multiformats/multiaddr#181
Added
SNI, NOISE, CERTHASH, WEBRTC, WEBRTC-DIRECT
protocol in py-multiaddr in reference with go-multiaddrSNI
had the same codec configs as DNS in go-multiaddrSo just added this line in the protocol registry
Did the same thing with
NOISE
Added the
CERTHASH
protocol as per go implementation