Skip to content

Fix getVehicleCompatibleUpgrades #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix getVehicleCompatibleUpgrades #3318

wants to merge 10 commits into from

Conversation

znvjder
Copy link
Contributor

@znvjder znvjder commented Feb 19, 2024

The PR fixes the issue with incorrect display of vehicle upgrades compatibility in serverside.

Resolves #2476 and #3248.

tederis
tederis reviewed Feb 20, 2024
View reviewed changes
@Nico8340
Copy link
Member

Nico8340 commented Mar 9, 2024

Marge :shipit:

@TheNormalnij TheNormalnij added the bugfix Solution to a bug of any kind label Mar 17, 2024
@TheNormalnij
Copy link
Member

Is this upgrade list wrong?
This PR removes a lot of vehicle upgrades from client and server sides.
Is your list correct?

client_after.json
client_before.json
server_after.json
server_before.json

@Dutchman101 Dutchman101 added the feedback Further information is requested label May 25, 2024
Dutchman101
Dutchman101 requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@Dutchman101 Dutchman101 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TheNormalnij's feedback must be addressed before merge
cc @znvjder

@tederis
Copy link
Member

tederis commented May 31, 2025

@znvjder Please, address the feedback given earlier by TheNormalnij

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dutchman101 Dutchman101 Dutchman101 requested changes

@tederis tederis tederis approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bugfix Solution to a bug of any kind feedback Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getVehicleCompatibleUpgrades returns different value on serverside and clientside
5 participants
@znvjder @Nico8340 @TheNormalnij @tederis @Dutchman101