Fix & improvement getPedMoveState #4316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1598 #1594 #1590
The
getPedMoveState
function behaves somewhat unreliably. It often incorrectly returns fall, which is caused by the imprecise behavior of IsOnGround (in some areas of the map, the player's position might be, for example, z = 8.5, while the ground is z = 7.5).This PR fixes the mentioned issues and adds new states (previously incorrectly labeled as fall):
roll
stateHere is a screenshot of one of the reported issues I received:

Thanks to @sacr1ficez for reporting in DM