Fix IsPedInVehicle synchronization issue between server and client#4420
Open
Serius41 wants to merge 2 commits into
Open
Fix IsPedInVehicle synchronization issue between server and client#4420Serius41 wants to merge 2 commits into
Serius41 wants to merge 2 commits into
Conversation
isPedInVehicle was returning true on the server side even if the ped was not in the vehicle. Here we had to check if there was a groove in the vehicle, and the values were returning differently between the client and server.
Serius41
changed the title
FileEX
requested changes
Sep 5, 2025
FileEX
reviewed
Sep 5, 2025
FileEX
added
backwards-incompatible
Member
|
Hmmm... Is this a side effect (bug) or an intended effect? It seems to me that on the server side it should work the same way as on the client side. Related #3830 |
Member
|
@Serius41 Do you have plans to respond to the feedback, or was this PR abandoned the day you opened it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix IsPedInVehicle synchronization issue between server and client
Fixes issue where setPedEnterVehicle would cause server-side IsPedInVehicle
to return true before ped actually entered the vehicle, while client-side
correctly returned false until ped was physically in the vehicle.
bug:
fixed:
