Fixes api block by miiu96 · Pull Request #7797 · multiversx/mx-chain-go

miiu96 · 2026-03-20T07:56:33Z

Reasoning behind the pull request

Fixes API block
Fixes GetBulkFromEpoch from fullHistoryPrunningStorer

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

codecov · 2026-03-20T08:11:34Z

Codecov Report

❌ Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.53%. Comparing base (8eab550) to head (37ff483).

Files with missing lines	Patch %	Lines
node/external/blockAPI/baseBlock.go	83.33%	1 Missing and 1 partial ⚠️
node/external/blockAPI/check.go	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                      Coverage Diff                      @@
##           feat/supernova-async-exec    #7797      +/-   ##
=============================================================
- Coverage                      77.54%   77.53%   -0.01%     
=============================================================
  Files                            882      882              
  Lines                         123683   123646      -37     
=============================================================
- Hits                           95908    95870      -38     
- Misses                         21429    21434       +5     
+ Partials                        6346     6342       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ssd04 · 2026-03-20T13:14:58Z

node/external/blockAPI/metaBlock.go

-		NumTxs:                 numOfTxs,
 		NotarizedBlocks:        notarizedBlocks,
-		MiniBlocks:             miniblocks,


add activation flag check for this? or maybe better keep it as before, with propored miniblocks and num of txs?

ssd04 · 2026-03-20T13:15:21Z

node/external/blockAPI/shardBlock.go

-		NumTxs:          numOfTxs,
-		MiniBlocks:      miniblocks,


Copilot

Pull request overview

This PR updates the block API receipts-loading flow to correctly handle protocol differences (incl. Supernova round activation) by threading round/receipts-hash context through the API block processors and receipts repository.

Changes:

Extends LoadReceipts to accept an explicit receiptsHash and updates all call sites/tests accordingly.
Adds EnableRoundsHandler plumbing into the block API processor args and processors; uses it to select the correct storage unit for receipts.
Refactors shard/meta API block conversion to delegate miniblock/tx counting logic to shared helpers and adds an integration-style simulator test for receipts.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
testscommon/receiptsRepositoryStub.go	Updates stub to match new `LoadReceipts(receiptsHash, header, headerHash)` signature.
process/receipts/receiptsRepository.go	Updates repository `LoadReceipts` signature and storage-key selection input.
process/receipts/receiptsRepository_test.go	Adjusts tests to pass `receiptsHash` explicitly.
node/external/blockAPI/interface.go	Updates internal blockAPI receipts repository interface signature.
node/external/blockAPI/blockArgs.go	Adds `EnableRoundHandler` arg (rounds handler) for block API processor construction.
node/external/blockAPI/check.go	Validates non-nil rounds handler in args.
node/external/blockAPI/baseBlock.go	Uses rounds flag to choose receipts storer unit; passes explicit receipts hash to receipts repo for intrashard miniblocks.
node/external/blockAPI/baseBlock_test.go	Updates tests to the new receipts-loading API and handler plumbing.
node/external/blockAPI/shardBlock.go	Refactors conversion to use helper methods; updates intrashard receipts miniblock loading signature.
node/external/blockAPI/metaBlock.go	Same as shardBlock: refactor + updated intrashard receipts miniblock loading signature.
node/external/blockAPI/apiBlockFactory_test.go	Updates block API processor args to include rounds handler.
node/chainSimulator/chainSimulator_test.go	Adds a simulator test asserting receipts are exposed correctly across Supernova activation.
factory/interface.go	Updates public `ReceiptsRepository` interface signature.
factory/api/apiResolverFactory.go	Wires `EnableRoundsHandler()` into block API processor args.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-23T08:49:48Z

node/external/blockAPI/baseBlock.go


 	allMbs := append(mbsBeforeExecutionAndCleanup, mbsAfterExecution...)
-	intraMb, err := bap.getIntrashardMiniblocksFromReceiptsStorage(blockHeader, headerHash, options)
+	receiptsHash := executionResultHandler.GetReceiptsHash()


In async execution, receiptsHash := executionResultHandler.GetReceiptsHash() can be nil/empty (e.g. if the field is missing in older execution results / default-initialized). Passing that through to LoadReceipts makes decideStorageKey choose an empty key instead of falling back to the header hash for the empty-receipts case, which can prevent intrashard miniblocks from being loaded. Consider falling back to blockHeader.GetReceiptsHash() (or to bap.emptyReceiptsHash) when len(receiptsHash)==0 before calling getIntrashardMiniblocksFromReceiptsStorage.

Suggested change

receiptsHash := executionResultHandler.GetReceiptsHash()

receiptsHash := executionResultHandler.GetReceiptsHash()

if len(receiptsHash) == 0 {

// Fallback to the block header receipts hash for older/default async results

receiptsHash = blockHeader.GetReceiptsHash()

}

if len(receiptsHash) == 0 {

// If still empty, use the predefined empty receipts hash

receiptsHash = bap.emptyReceiptsHash

}

Copilot · 2026-03-23T08:49:49Z

node/external/blockAPI/blockArgs.go

 	AccountsRepository           state.AccountsRepository
 	ScheduledTxsExecutionHandler process.ScheduledTxsExecutionHandler
 	EnableEpochsHandler          common.EnableEpochsHandler
+	EnableRoundHandler           common.EnableRoundsHandler


ArgAPIBlockProcessor introduces an exported field named EnableRoundHandler, but the type and the rest of the codebase use EnableRoundsHandler (plural). This inconsistency is easy to trip over and makes the API args less discoverable; consider renaming the field to EnableRoundsHandler and updating call sites accordingly.

Suggested change

EnableRoundHandler common.EnableRoundsHandler

EnableRoundsHandler common.EnableRoundsHandler

Copilot · 2026-03-23T08:49:49Z

node/chainSimulator/chainSimulator_test.go

 	chainSimulatorCommon.CheckGenerateTransactions(t, chainSimulator)
 }

+func TestSimilator_MoveBalanceCheckReceipt(t *testing.T) {


The test name TestSimilator_MoveBalanceCheckReceipt is misspelled (Similator). Since Go test selection relies on Test... names, consider correcting it to TestSimulator_MoveBalanceCheckReceipt for consistency and easier discovery.

Suggested change

func TestSimilator_MoveBalanceCheckReceipt(t *testing.T) {

func TestSimulator_MoveBalanceCheckReceipt(t *testing.T) {

Copilot · 2026-03-23T08:49:49Z

node/chainSimulator/chainSimulator_test.go

+				require.Equal(te, value, mb.Receipts[0].Value.String())
+			}
+		}
+		require.True(t, called)


Inside checkReceipts, assertions mostly use the te parameter, but the final assertion uses the outer t (require.True(t, called)). This can report failures on the wrong *testing.T (especially if this helper is reused in subtests). Use te consistently for all assertions in this helper.

Suggested change

require.True(t, called)

require.True(te, called)

BeniaminDrasovean · 2026-03-23T08:47:58Z

node/chainSimulator/chainSimulator_test.go

 	chainSimulatorCommon.CheckGenerateTransactions(t, chainSimulator)
 }

+func TestSimilator_MoveBalanceCheckReceipt(t *testing.T) {


Simulator instead of Similator

fixes api block

601eece

miiu96 self-assigned this Mar 20, 2026

extra checks

71ff436

ssd04 self-requested a review March 20, 2026 13:10

ssd04 reviewed Mar 20, 2026

View reviewed changes

BeniaminDrasovean requested a review from Copilot March 23, 2026 08:45

Copilot started reviewing on behalf of BeniaminDrasovean March 23, 2026 08:45 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

BeniaminDrasovean reviewed Mar 23, 2026

View reviewed changes

miiu96 added 8 commits March 24, 2026 10:43

extra logs for testing

415cacd

extra logs for testing

051f3df

fix fix

5618527

one more check

b3b2757

proper fix

b542cf9

uni tests

225c731

fixes after review

839cef7

fix unit tests

37ff483

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes api block#7797

Fixes api block#7797
miiu96 wants to merge 10 commits intofeat/supernova-async-execfrom
fix-api-block-receipts

miiu96 commented Mar 20, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

ssd04 Mar 20, 2026

Uh oh!

ssd04 Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

BeniaminDrasovean Mar 23, 2026

Uh oh!

miiu96 Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-	receiptsHash := executionResultHandler.GetReceiptsHash()
+	receiptsHash := executionResultHandler.GetReceiptsHash()
+	if len(receiptsHash) == 0 {
+		// Fallback to the block header receipts hash for older/default async results
+		receiptsHash = blockHeader.GetReceiptsHash()
+	}
+	if len(receiptsHash) == 0 {
+		// If still empty, use the predefined empty receipts hash
+		receiptsHash = bap.emptyReceiptsHash
+	}

	EnableRoundHandler common.EnableRoundsHandler
	EnableRoundsHandler common.EnableRoundsHandler

	func TestSimilator_MoveBalanceCheckReceipt(t *testing.T) {
	func TestSimulator_MoveBalanceCheckReceipt(t *testing.T) {

Conversation

miiu96 commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reasoning behind the pull request

Pre-requisites

Uh oh!

codecov bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ssd04 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

ssd04 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

BeniaminDrasovean Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

miiu96 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

miiu96 commented Mar 20, 2026 •

edited

Loading

codecov bot commented Mar 20, 2026 •

edited

Loading