Skip to content

Update initial facade metrics#7799

Open
ssd04 wants to merge 2 commits intofeat/supernova-async-execfrom
update-initial-facade-metrics
Open

Update initial facade metrics#7799
ssd04 wants to merge 2 commits intofeat/supernova-async-execfrom
update-initial-facade-metrics

Conversation

@ssd04
Copy link
Contributor

@ssd04 ssd04 commented Mar 23, 2026

Reasoning behind the pull request

  • Updated initial node facade to include also node status metrics. These includes metrics based on config values and core components status
  • Updated termui to check for sync status before setting shard id string

Testing procedure

  • Standard system test
  • temrui tool testing in sync mode

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@ssd04 ssd04 self-assigned this Mar 23, 2026
Comment on lines +311 to +320
appStatusHandler.SetStringValue(common.MetricPublicKeyBlockSign, pubkeyStr)
appStatusHandler.SetStringValue(common.MetricAppVersion, version)
appStatusHandler.SetStringValue(common.MetricCrossCheckBlockHeight, "0")
appStatusHandler.SetUInt64Value(common.MetricCrossCheckBlockHeightMeta, 0)
appStatusHandler.SetUInt64Value(common.MetricIsSyncing, isSyncing)
appStatusHandler.SetStringValue(common.MetricLeaderPercentage, fmt.Sprintf("%f", leaderPercentage))
appStatusHandler.SetUInt64Value(common.MetricDenomination, uint64(economicsConfig.GlobalSettings.Denomination))

appStatusHandler.SetUInt64Value(common.MetricStartTime, uint64(nodesConfig.GetStartTime()))
appStatusHandler.SetUInt64Value(common.MetricMinTransactionVersion, uint64(minTransactionVersion))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these set of metrics will be overwritten after bootstrap is finished

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 0% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.50%. Comparing base (8eab550) to head (4bb2624).

Files with missing lines Patch % Lines
node/metrics/metrics.go 0.00% 26 Missing ⚠️
node/nodeRunner.go 0.00% 26 Missing ⚠️
...termui/view/termuic/termuiRenders/widgetsRender.go 0.00% 15 Missing ⚠️
facade/initial/initialStatusMetricsProvider.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat/supernova-async-exec    #7799      +/-   ##
=============================================================
- Coverage                      77.54%   77.50%   -0.05%     
=============================================================
  Files                            882      882              
  Lines                         123683   123738      +55     
=============================================================
- Hits                           95908    95901       -7     
- Misses                         21429    21494      +65     
+ Partials                        6346     6343       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant