Skip to content

Fix round index timestamp#7801

Merged
miiu96 merged 2 commits intofeat/supernova-async-execfrom
fix-rounds-index-missing-timestamp-ms
Mar 26, 2026
Merged

Fix round index timestamp#7801
miiu96 merged 2 commits intofeat/supernova-async-execfrom
fix-rounds-index-missing-timestamp-ms

Conversation

@miiu96
Copy link
Copy Markdown
Contributor

@miiu96 miiu96 commented Mar 25, 2026

Reasoning behind the pull request

  • Fixes RoundInfo structure that is used in OutportDriver
  • timestampMs field is not populated for the case when a block is not produced in a round

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@miiu96 miiu96 self-assigned this Mar 25, 2026
@miiu96 miiu96 merged commit f74ac76 into feat/supernova-async-exec Mar 26, 2026
9 checks passed
@miiu96 miiu96 deleted the fix-rounds-index-missing-timestamp-ms branch March 26, 2026 08:21
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.57%. Comparing base (2451f5b) to head (2569090).
⚠️ Report is 3 commits behind head on feat/supernova-async-exec.

Files with missing lines Patch % Lines
consensus/spos/bls/v2/subroundStartRound.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/supernova-async-exec    #7801   +/-   ##
==========================================================
  Coverage                      77.57%   77.57%           
==========================================================
  Files                            882      882           
  Lines                         123690   123698    +8     
==========================================================
+ Hits                           95954    95961    +7     
+ Misses                         21378    21377    -1     
- Partials                        6358     6360    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants