Skip to content

[SERVICES-1760] eslint fixes#1151

Open
claudiulataretu wants to merge 13 commits intodevelopmentfrom
SERVICES-1760-airbnb-eslint
Open

[SERVICES-1760] eslint fixes#1151
claudiulataretu wants to merge 13 commits intodevelopmentfrom
SERVICES-1760-airbnb-eslint

Conversation

@claudiulataretu
Copy link
Copy Markdown
Collaborator

Reasoning

  • eslint errors and warnings were not resolved

Proposed Changes

  • solve eslint errors and warnings
  • update eslint file
  • add linter workflow

How to test

  • N/A

Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 21, 2023

Codecov Report

❌ Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.51%. Comparing base (32e81ac) to head (fedc6c6).
⚠️ Report is 1946 commits behind head on development.

Files with missing lines Patch % Lines
...odules/auto-router/services/auto-router.service.ts 0.00% 5 Missing and 1 partial ⚠️
...ules/farm/base-module/services/farm.abi.service.ts 25.00% 5 Missing and 1 partial ⚠️
src/common.app.module.ts 0.00% 0 Missing and 2 partials ⚠️
...rc/modules/farm/v2/services/farm.v2.abi.service.ts 0.00% 1 Missing ⚠️
src/modules/pair/services/pair.abi.service.ts 0.00% 1 Missing ⚠️
src/utils/performance.profiler.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1151      +/-   ##
===============================================
- Coverage        56.52%   56.51%   -0.02%     
===============================================
  Files              235      235              
  Lines             7882     7887       +5     
  Branches           530      532       +2     
===============================================
+ Hits              4455     4457       +2     
- Misses            2974     2975       +1     
- Partials           453      455       +2     
Flag Coverage Δ
unittests 56.51% <22.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
- add ignore patterns for underscored variables

Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
dragos-rebegea
dragos-rebegea previously approved these changes Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants