Merged
Conversation
Fixed signing screens styles
radumojic
approved these changes
Mar 11, 2025
radumojic
approved these changes
Mar 11, 2025
CiprianDraghici
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Signing transactions on the extension would break the layout, creating an unnecessary scroll and spacing the elements out more than necessary.
Reproduce
Signing a transaction with the extension while not in full screen mode, that will also trigger the extension to not open in full screen mode.
Issue exists on
v3.2.5ofsdk-dapp.Fix
Aligned the buttons on the same row and slightly altered the spacing.
Contains breaking changes
Updated CHANGELOG
Testing