Fixed cancel action is not called on all providers#1383
Merged
razvantomegea merged 2 commits intodevelopmentfrom Mar 12, 2025
Merged
Fixed cancel action is not called on all providers#1383razvantomegea merged 2 commits intodevelopmentfrom
razvantomegea merged 2 commits intodevelopmentfrom
Conversation
radumojic
approved these changes
Mar 11, 2025
arhtudormorar
approved these changes
Mar 12, 2025
razvantomegea
added a commit
that referenced
this pull request
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Multiple extension windows/popups appear after cancelling a transaction from the "Confirm on Defi Wallet" modal. Also, no sign transaction modal appears in the extension.
Root cause
Cancel action is not called when "Close" button is click in the "Confirm on Defi Wallet" modal.
Contains breaking changes
Updated CHANGELOG
Testing