Skip to content

Lottery SC audit fixes #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alyn509 wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Lottery SC audit fixes #1765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
e8915fb
audit changed + part 1 test fixes
alyn509 Sep 4, 2024
c04196a
Merge branch 'master' into audit-lottery
alyn509 Sep 4, 2024
da3272d
clippy
alyn509 Sep 4, 2024
61a1a4d
Merge branch 'master' into audit-lottery
alyn509 Sep 5, 2024
f6e2f8e
caller of Determine_winner on remote shard (disabled)
alyn509 Sep 25, 2024
0232fda
index last winner update
alyn509 Sep 25, 2024
7fd5918
fix after Dorin's review
alyn509 Oct 2, 2024
c9c2a98
fix tests part 1
alyn509 Oct 2, 2024
f215535
Merge branch 'master' into audit-lottery
alyn509 Oct 2, 2024
381f5de
test fixes part 2
alyn509 Oct 2, 2024
cbb5551
Merge branch 'master' into audit-lottery
alyn509 Nov 12, 2024
5431cd5
different shard call tests update
alyn509 Nov 19, 2024
d484dc4
Merge branch 'master' into audit-lottery
alyn509 Nov 19, 2024
e6093b1
Merge branch 'master' into audit-lottery
alyn509 Dec 10, 2024
15f9b29
fix reward amount not getting changed
alyn509 Dec 16, 2024
0696382
Merge branch 'master' into audit-lottery
alyn509 Dec 16, 2024
00b5a4e
clippy
alyn509 Dec 16, 2024
3da60f8
reorgazing
alyn509 Dec 16, 2024
a8b4ca7
more refactoring
alyn509 Dec 16, 2024
f3ba4b7
Merge branch 'master' into audit-lottery
alyn509 Jan 31, 2025
100b212
payment part refactoring
alyn509 Jan 31, 2025
835630f
proxy & chain simulator test setup
alyn509 Feb 3, 2025
4f38dd1
naming fix + add comment
alyn509 Feb 3, 2025
6040793
Merge branch 'master' into audit-lottery
alyn509 Feb 3, 2025
ee4fffd
switch back to TestAddress
alyn509 Feb 3, 2025
11e5919
Merge branch 'master' into audit-lottery
alyn509 Feb 17, 2025
8fb8294
Merge branch 'master' into audit-lottery
alyn509 Feb 17, 2025
f80d2b5
remove blackbox test - cannot simulate shard with it anyway
alyn509 Feb 24, 2025
2f6c528
ignore tests that require different shard calls
alyn509 Feb 25, 2025
e7c75ef
sc-meta all update
alyn509 Feb 25, 2025
f495184
Merge branch 'rc/v0.57' into audit-lottery
alyn509 Mar 4, 2025
4cd5b87
Merge branch 'master' into audit-lottery
alyn509 Oct 9, 2025
94b8b9a
name fixes
alyn509 Oct 9, 2025
431c2a1
cargo toml
alyn509 Oct 9, 2025
7f8b37e
Merge branch 'master' into audit-lottery
alyn509 Oct 28, 2025
b34c7e1
cleanup
alyn509 Nov 3, 2025
7f80c56
dedup init lottery endpoints
alyn509 Nov 17, 2025
8531f27
Merge branch 'master' into audit-lottery
alyn509 Nov 17, 2025
4b82edb
Merge branch 'master' into audit-lottery
alyn509 Nov 17, 2025
a9d65ff
scenario tests fix
alyn509 Nov 17, 2025
61d070a
start lottery endpoint
alyn509 Nov 17, 2025
cf3e8df
regenerate proxy
alyn509 Nov 18, 2025
28c7584
Merge branch 'master' into audit-lottery
alyn509 Nov 19, 2025
9fcc9cb
Merge branch 'master' into audit-lottery
alyn509 Dec 10, 2025
72c27ac
Merge branch 'master' into audit-lottery
andrei-marinica Mar 6, 2026
6aa699f
migrate mod.rs
andrei-marinica Mar 6, 2026
3b3ef59
lottery - fix deprecations
andrei-marinica Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/examples/lottery-esdt/sc-config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[settings]

[[proxy]]
path = "src/lottery_proxy.rs"
51 changes: 34 additions & 17 deletions contracts/examples/lottery-esdt/scenarios/buy-all-tickets-different-accounts.scen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"id": "buy-ticket-acc1",
"tx": {
"from": "address:acc1",
"to": "sc:lottery",
"to": "sc:lottery#42",
"esdtValue": [
{
"tokenIdentifier": "str:LOTTERY-123456",
Expand All @@ -77,7 +77,7 @@
"id": "buy-ticket-acc2",
"tx": {
"from": "address:acc2",
"to": "sc:lottery",
"to": "sc:lottery#42",
"esdtValue": [
{
"tokenIdentifier": "str:LOTTERY-123456",
Expand All @@ -103,7 +103,7 @@
"id": "buy-ticket-acc3",
"tx": {
"from": "address:acc3",
"to": "sc:lottery",
"to": "sc:lottery#42",
"esdtValue": [
{
"tokenIdentifier": "str:LOTTERY-123456",
Expand All @@ -129,7 +129,7 @@
"id": "buy-ticket-acc4",
"tx": {
"from": "address:acc4",
"to": "sc:lottery",
"to": "sc:lottery#42",
"esdtValue": [
{
"tokenIdentifier": "str:LOTTERY-123456",
Expand All @@ -155,7 +155,7 @@
"id": "buy-ticket-acc5",
"tx": {
"from": "address:acc5",
"to": "sc:lottery",
"to": "sc:lottery#42",
"esdtValue": [
{
"tokenIdentifier": "str:LOTTERY-123456",
Expand Down Expand Up @@ -184,6 +184,11 @@
"balance": "1,000,000",
"storage": {}
},
"address:other_shard_address#41": {
"nonce": "0",
"balance": "1,000,000",
"storage": {}
},
"address:acc1": {
"nonce": "1",
"balance": "1,000,000",
Expand All @@ -209,7 +214,7 @@
"balance": "1,000,000",
"storage": {}
},
"sc:lottery": {
"sc:lottery#42": {
"nonce": "0",
"balance": "0",
"esdt": {
Expand All @@ -223,19 +228,31 @@
"3-deadline": "u64:123,456",
"4-max_entries_per_user": "u32:1",
"5-prize_distribution": "u32:2|u8:75|u8:25",
"6-prize_pool": "biguint:500"
"6-prize_pool": "biguint:500",
"7-unawarded_amount": "biguint:500"
},
"str:ticketHolder|nested:str:lottery_name|str:.len": "5",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:1": "address:acc1",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:2": "address:acc2",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:3": "address:acc3",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:4": "address:acc4",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:5": "address:acc5",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|address:acc1": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|address:acc2": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|address:acc3": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|address:acc4": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|address:acc5": "1",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:1": "1",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:2": "2",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:3": "3",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:4": "4",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:5": "5",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|u64:1": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|u64:2": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|u64:3": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|u64:4": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|u64:5": "1",
"str:addressToIdMapper|str:lastId": "5",
"str:addressToIdMapper|str:addr|address:acc1": "1",
"str:addressToIdMapper|str:addrId|u64:1": "address:acc1",
"str:addressToIdMapper|str:addr|address:acc2": "2",
"str:addressToIdMapper|str:addrId|u64:2": "address:acc2",
"str:addressToIdMapper|str:addr|address:acc3": "3",
"str:addressToIdMapper|str:addrId|u64:3": "address:acc3",
"str:addressToIdMapper|str:addr|address:acc4": "4",
"str:addressToIdMapper|str:addrId|u64:4": "address:acc4",
"str:addressToIdMapper|str:addr|address:acc5": "5",
"str:addressToIdMapper|str:addrId|u64:5": "address:acc5",
"+": ""
},
"code": "mxsc:../output/lottery-esdt.mxsc.json"
Expand Down
22 changes: 17 additions & 5 deletions contracts/examples/lottery-esdt/scenarios/buy-more-tickets-than-allowed.scen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"id": "buy-more-tickets-than-allowed",
"tx": {
"from": "address:acc1",
"to": "sc:lottery",
"to": "sc:lottery#42",
"esdtValue": [
{
"tokenIdentifier": "str:LOTTERY-123456",
Expand Down Expand Up @@ -53,6 +53,11 @@
"balance": "1,000,000",
"storage": {}
},
"address:other_shard_address#41": {
"nonce": "0",
"balance": "1,000,000",
"storage": {}
},
"address:acc1": {
"nonce": "2",
"balance": "1,000,000",
Expand All @@ -66,7 +71,7 @@
"balance": "1,000,000",
"storage": {}
},
"sc:lottery": {
"sc:lottery#42": {
"nonce": "0",
"balance": "0",
"esdt": {
Expand All @@ -80,11 +85,18 @@
"3-deadline": "u64:123,456",
"4-max_entries_per_user": "u32:1",
"5-prize_distribution": "u32:2|u8:75|u8:25",
"6-prize_pool": "biguint:100"
"6-prize_pool": "biguint:100",
"7-unawarded_amount": "biguint:100"
},
"str:ticketHolder|nested:str:lottery_name|str:.len": "1",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:1": "address:acc1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|address:acc1": "1",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:1": "2",
"str:addressToIdMapper|str:lastId": "3",
"str:addressToIdMapper|str:addr|address:my_address": "1",
"str:addressToIdMapper|str:addrId|u64:1": "address:my_address",
"str:addressToIdMapper|str:addr|address:acc1": "2",
"str:addressToIdMapper|str:addrId|u64:2": "address:acc1",
"str:addressToIdMapper|str:addr|address:acc2": "3",
"str:addressToIdMapper|str:addrId|u64:3": "address:acc2",
"+": ""
},
"code": "mxsc:../output/lottery-esdt.mxsc.json"
Expand Down
19 changes: 14 additions & 5 deletions contracts/examples/lottery-esdt/scenarios/buy-ticket-after-deadline.scen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"id": "buy-ticket-after-deadline",
"tx": {
"from": "address:acc2",
"to": "sc:lottery",
"to": "sc:lottery#42",
"esdtValue": [
{
"tokenIdentifier": "str:LOTTERY-123456",
Expand Down Expand Up @@ -56,6 +56,11 @@
"balance": "1,000,000",
"storage": {}
},
"address:other_shard_address#41": {
"nonce": "0",
"balance": "1,000,000",
"storage": {}
},
"address:acc1": {
"nonce": "1",
"balance": "1,000,000",
Expand All @@ -69,7 +74,7 @@
},
"storage": {}
},
"sc:lottery": {
"sc:lottery#42": {
"nonce": "0",
"balance": "0",
"esdt": {
Expand All @@ -83,11 +88,15 @@
"3-deadline": "u64:123,456",
"4-max_entries_per_user": "u32:800",
"5-prize_distribution": "nested:u8:100",
"6-prize_pool": "biguint:100"
"6-prize_pool": "biguint:100",
"7-unawarded_amount": "biguint:100"
},
"str:ticketHolder|nested:str:lottery_name|str:.len": "1",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:1": "address:acc1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|address:acc1": "1"
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:1": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|u64:1": "1",
"str:addressToIdMapper|str:lastId": "1",
"str:addressToIdMapper|str:addr|address:acc1": "1",
"str:addressToIdMapper|str:addrId|u64:1": "address:acc1"
},
"code": "mxsc:../output/lottery-esdt.mxsc.json"
}
Expand Down
19 changes: 15 additions & 4 deletions contracts/examples/lottery-esdt/scenarios/buy-ticket-after-determined-winner.scen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"id": "buy-ticket-after-announced-winner",
"tx": {
"from": "address:acc1",
"to": "sc:lottery",
"to": "sc:lottery#42",
"esdtValue": [
{
"tokenIdentifier": "str:LOTTERY-123456",
Expand All @@ -49,7 +49,12 @@
"step": "checkState",
"accounts": {
"address:my_address": {
"nonce": "3",
"nonce": "2",
"balance": "1,000,000",
"storage": {}
},
"address:other_shard_address#41": {
"nonce": "1",
"balance": "1,000,000",
"storage": {}
},
Expand All @@ -66,10 +71,16 @@
"balance": "1,000,000",
"storage": {}
},
"sc:lottery": {
"sc:lottery#42": {
"nonce": "0",
"balance": "0",
"storage": {},
"storage": {
"str:addressToIdMapper|str:lastId": "2",
"str:addressToIdMapper|str:addr|address:acc1": "1",
"str:addressToIdMapper|str:addrId|u64:1": "address:acc1",
"str:addressToIdMapper|str:addr|address:acc2": "2",
"str:addressToIdMapper|str:addrId|u64:2": "address:acc2"
},
"code": "mxsc:../output/lottery-esdt.mxsc.json"
}
}
Expand Down
25 changes: 18 additions & 7 deletions contracts/examples/lottery-esdt/scenarios/buy-ticket-after-sold-out.scen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"id": "buy-ticket-after-sold-out",
"tx": {
"from": "address:acc1",
"to": "sc:lottery",
"to": "sc:lottery#42",
"esdtValue": [
{
"tokenIdentifier": "str:LOTTERY-123456",
Expand Down Expand Up @@ -53,6 +53,11 @@
"balance": "1,000,000",
"storage": {}
},
"address:other_shard_address#41": {
"nonce": "0",
"balance": "1,000,000",
"storage": {}
},
"address:acc1": {
"nonce": "2",
"balance": "1,000,000",
Expand All @@ -66,7 +71,7 @@
"balance": "1,000,000",
"storage": {}
},
"sc:lottery": {
"sc:lottery#42": {
"nonce": "0",
"balance": "0",
"esdt": {
Expand All @@ -80,13 +85,19 @@
"3-deadline": "u64:123,456",
"4-max_entries_per_user": "u32:800",
"5-prize_distribution": "nested:u8:100",
"6-prize_pool": "biguint:200"
"6-prize_pool": "biguint:200",
"7-unawarded_amount": "biguint:200"
},
"str:ticketHolder|nested:str:lottery_name|str:.len": "2",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:1": "address:acc1",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:2": "address:acc2",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|address:acc1": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|address:acc2": "1"
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:1": "1",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:2": "2",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|u64:1": "1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|u64:2": "1",
"str:addressToIdMapper|str:lastId": "2",
"str:addressToIdMapper|str:addr|address:acc1": "1",
"str:addressToIdMapper|str:addrId|u64:1": "address:acc1",
"str:addressToIdMapper|str:addr|address:acc2": "2",
"str:addressToIdMapper|str:addrId|u64:2": "address:acc2"
},
"code": "mxsc:../output/lottery-esdt.mxsc.json"
}
Expand Down
17 changes: 12 additions & 5 deletions contracts/examples/lottery-esdt/scenarios/buy-ticket-all-options.scen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"id": "buy-ticket",
"tx": {
"from": "address:acc1",
"to": "sc:lottery",
"to": "sc:lottery#42",
"esdtValue": [
{
"tokenIdentifier": "str:LOTTERY-123456",
Expand Down Expand Up @@ -52,6 +52,11 @@
"balance": "1,000,000",
"storage": {}
},
"address:other_shard_address#41": {
"nonce": "0",
"balance": "1,000,000",
"storage": {}
},
"address:acc1": {
"nonce": "1",
"balance": "1,000,000",
Expand All @@ -62,7 +67,7 @@
"balance": "1,000,000",
"storage": {}
},
"sc:lottery": {
"sc:lottery#42": {
"nonce": "0",
"balance": "0",
"esdt": {
Expand All @@ -76,11 +81,13 @@
"3-deadline": "u64:123,456",
"4-max_entries_per_user": "u32:1",
"5-prize_distribution": "u32:2|u8:75|u8:25",
"6-prize_pool": "biguint:100"
"6-prize_pool": "biguint:100",
"7-unawarded_amount": "biguint:100"
},
"str:ticketHolder|nested:str:lottery_name|str:.len": "1",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:1": "address:acc1",
"str:numberOfEntriesForUser|u32:12|str:lottery_name|address:acc1": "1",
"str:ticketHolder|nested:str:lottery_name|str:.item|u32:1": "2",
"str:addressToIdMapper|str:addr|address:my_address": "1",
"str:addressToIdMapper|str:addrId|u64:1": "address:my_address",
"+": ""
},
"code": "mxsc:../output/lottery-esdt.mxsc.json"
Expand Down
Loading