Skip to content

[DO NOT MERGE] Rust edition 2024 - clippy fixes #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andrei-marinica wants to merge 2 commits into
base: master
Choose a base branch
from

fmt after clippy after edition 2024

68949ea
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

[DO NOT MERGE] Rust edition 2024 - clippy fixes #2251

fmt after clippy after edition 2024
68949ea
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy failed Dec 16, 2025 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (9)

data/codec-derive/src/util.rs|168 col 8| error[E0658]: let expressions in this position are unstable
--> data/codec-derive/src/util.rs:168:8
|
168 | if let syn::Type::Path(ref mut p) = field
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #53667 rust-lang/rust#53667 for more information
framework/derive/src/generate/convert_to_owned_type.rs|21 col 19| error[E0658]: let expressions in this position are unstable
--> framework/derive/src/generate/convert_to_owned_type.rs:21:19
|
21 | } else if let syn::Type::Path(syn::TypePath { path, .. }) = &*type_reference.elem
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #53667 rust-lang/rust#53667 for more information
framework/derive/src/generate/convert_to_owned_type.rs|22 col 16| error[E0658]: let expressions in this position are unstable
--> framework/derive/src/generate/convert_to_owned_type.rs:22:16
|
22 | && let Some(ident) = path.get_ident()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #53667 rust-lang/rust#53667 for more information
framework/derive/src/generate/restricted_caller_gen.rs|4 col 8| error[E0658]: let expressions in this position are unstable
--> framework/derive/src/generate/restricted_caller_gen.rs:4:8
|
4 | if let PublicRole::Endpoint(endpoint_metadata) = &m.public_role
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #53667 rust-lang/rust#53667 for more information
framework/derive/src/generate/restricted_caller_gen.rs|15 col 8| error[E0658]: let expressions in this position are unstable
--> framework/derive/src/generate/restricted_caller_gen.rs:15:8
|
15 | if let PublicRole::Endpoint(endpoint_metadata) = &m.public_role
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #53667 rust-lang/rust#53667 for more information
framework/derive/src/generate/restricted_caller_gen.rs|26 col 8| error[E0658]: let expressions in this position are unstable
--> framework/derive/src/generate/restricted_caller_gen.rs:26:8
|
26 | if let PublicRole::Endpoint(endpoint_metadata) = &m.public_role
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #53667 rust-lang/rust#53667 for more information
framework/derive/src/parse/attributes/doc_attr.rs|52 col 12| error[E0658]: let expressions in this position are unstable
--> framework/derive/src/parse/attributes/doc_attr.rs:52:12
|
52 | if let syn::Meta::List(list) = &a.meta
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #53667 rust-lang/rust#53667 for more information
framework/derive/src/parse/attributes/util.rs|4 col 8| error[E0658]: let expressions in this position are unstable
--> framework/derive/src/parse/attributes/util.rs:4:8
|
4 | if let Some(first_seg) = attr.path().segments.first()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #53667 rust-lang/rust#53667 for more information
framework/derive/src/parse/attributes/util.rs|22 col 8| error[E0658]: let expressions in this position are unstable
--> framework/derive/src/parse/attributes/util.rs:22:8
|
22 | if let Some(first_seg) = attr_path.segments.first()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #53667 rust-lang/rust#53667 for more information

Filtered Findings (0)

Annotations

Check failure on line 168 in data/codec-derive/src/util.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] data/codec-derive/src/util.rs#L168 

error[E0658]: `let` expressions in this position are unstable
   --> data/codec-derive/src/util.rs:168:8
    |
168 |     if let syn::Type::Path(ref mut p) = field
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
Raw output 
data/codec-derive/src/util.rs:168:8:e:error[E0658]: `let` expressions in this position are unstable
   --> data/codec-derive/src/util.rs:168:8
    |
168 |     if let syn::Type::Path(ref mut p) = field
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information


__END__

Check failure on line 21 in framework/derive/src/generate/convert_to_owned_type.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/generate/convert_to_owned_type.rs#L21 

error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/generate/convert_to_owned_type.rs:21:19
   |
21 |         } else if let syn::Type::Path(syn::TypePath { path, .. }) = &*type_reference.elem
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
Raw output 
framework/derive/src/generate/convert_to_owned_type.rs:21:19:e:error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/generate/convert_to_owned_type.rs:21:19
   |
21 |         } else if let syn::Type::Path(syn::TypePath { path, .. }) = &*type_reference.elem
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information


__END__

Check failure on line 22 in framework/derive/src/generate/convert_to_owned_type.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/generate/convert_to_owned_type.rs#L22 

error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/generate/convert_to_owned_type.rs:22:16
   |
22 |             && let Some(ident) = path.get_ident()
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
Raw output 
framework/derive/src/generate/convert_to_owned_type.rs:22:16:e:error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/generate/convert_to_owned_type.rs:22:16
   |
22 |             && let Some(ident) = path.get_ident()
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information


__END__

Check failure on line 4 in framework/derive/src/generate/restricted_caller_gen.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/generate/restricted_caller_gen.rs#L4 

error[E0658]: `let` expressions in this position are unstable
 --> framework/derive/src/generate/restricted_caller_gen.rs:4:8
  |
4 |     if let PublicRole::Endpoint(endpoint_metadata) = &m.public_role
  |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
Raw output 
framework/derive/src/generate/restricted_caller_gen.rs:4:8:e:error[E0658]: `let` expressions in this position are unstable
 --> framework/derive/src/generate/restricted_caller_gen.rs:4:8
  |
4 |     if let PublicRole::Endpoint(endpoint_metadata) = &m.public_role
  |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information


__END__

Check failure on line 15 in framework/derive/src/generate/restricted_caller_gen.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/generate/restricted_caller_gen.rs#L15 

error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/generate/restricted_caller_gen.rs:15:8
   |
15 |     if let PublicRole::Endpoint(endpoint_metadata) = &m.public_role
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
Raw output 
framework/derive/src/generate/restricted_caller_gen.rs:15:8:e:error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/generate/restricted_caller_gen.rs:15:8
   |
15 |     if let PublicRole::Endpoint(endpoint_metadata) = &m.public_role
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information


__END__

Check failure on line 26 in framework/derive/src/generate/restricted_caller_gen.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/generate/restricted_caller_gen.rs#L26 

error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/generate/restricted_caller_gen.rs:26:8
   |
26 |     if let PublicRole::Endpoint(endpoint_metadata) = &m.public_role
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
Raw output 
framework/derive/src/generate/restricted_caller_gen.rs:26:8:e:error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/generate/restricted_caller_gen.rs:26:8
   |
26 |     if let PublicRole::Endpoint(endpoint_metadata) = &m.public_role
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information


__END__

Check failure on line 52 in framework/derive/src/parse/attributes/doc_attr.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/parse/attributes/doc_attr.rs#L52 

error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/parse/attributes/doc_attr.rs:52:12
   |
52 |         if let syn::Meta::List(list) = &a.meta
   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
Raw output 
framework/derive/src/parse/attributes/doc_attr.rs:52:12:e:error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/parse/attributes/doc_attr.rs:52:12
   |
52 |         if let syn::Meta::List(list) = &a.meta
   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information


__END__

Check failure on line 4 in framework/derive/src/parse/attributes/util.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/parse/attributes/util.rs#L4 

error[E0658]: `let` expressions in this position are unstable
 --> framework/derive/src/parse/attributes/util.rs:4:8
  |
4 |     if let Some(first_seg) = attr.path().segments.first()
  |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
Raw output 
framework/derive/src/parse/attributes/util.rs:4:8:e:error[E0658]: `let` expressions in this position are unstable
 --> framework/derive/src/parse/attributes/util.rs:4:8
  |
4 |     if let Some(first_seg) = attr.path().segments.first()
  |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information


__END__

Check failure on line 22 in framework/derive/src/parse/attributes/util.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/parse/attributes/util.rs#L22 

error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/parse/attributes/util.rs:22:8
   |
22 |     if let Some(first_seg) = attr_path.segments.first()
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
Raw output 
framework/derive/src/parse/attributes/util.rs:22:8:e:error[E0658]: `let` expressions in this position are unstable
  --> framework/derive/src/parse/attributes/util.rs:22:8
   |
22 |     if let Some(first_seg) = attr_path.segments.first()
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information


__END__
View more details on GitHub Actions