Skip to content

Interactor gas price, dex-interactor refactor#2321

Merged
andrei-marinica merged 2 commits intorc/v0.66from
dex-interactor-3
Mar 30, 2026
Merged

Interactor gas price, dex-interactor refactor#2321
andrei-marinica merged 2 commits intorc/v0.66from
dex-interactor-3

Conversation

@andrei-marinica
Copy link
Copy Markdown
Contributor

@andrei-marinica andrei-marinica commented Mar 26, 2026

Pull request overview

Updates the snippets interactor to allow an overridable gas price (instead of always using the network minimum), and refactors the forwarder-blind dex-interactor crate into clearer module/file names with a dedicated CLI/main entrypoint.

Changes:

  • Introduce gas_price on InteractorBase (defaulting to network_config.min_gas_price) and use it when building deploy/call transactions.
  • Refactor forwarder-blind dex-interactor into dex_interactor.rs + dex_interactor_cli.rs + dex_interactor_main.rs, and update Cargo.toml bin/lib paths.
  • Adjust dex-interactor to multiply the interactor gas price.

@github-actions
Copy link
Copy Markdown

Contract comparison - from 3c74a99 to b76fd8c

Path                                                                                             size                  has-allocator                     has-format
large-storage.wasm 1656 false None
vec-repeat.wasm 4872 false None
single-value-repeat.wasm 4253 false None
queue-repeat.wasm 5536 false None
linked-list-repeat.wasm 6838 false without message
map-repeat.wasm 7363 false without message
set-repeat.wasm 6511 false None
str-repeat.wasm 2733 false without message
str-repeat-mb-builder-cached.wasm 1109 false without message
str-repeat-mb-builder-basic.wasm 757 false None
send-tx-repeat.wasm 1292 false None
recursive-caller.wasm 5163 false without message
local-esdt-and-nft.wasm 12568 false without message
forwarder-raw-init-async-call.wasm 2374 false None
forwarder-raw-init-sync-call.wasm 2958 false None
forwarder-raw.wasm 13081 false None
vault-upgrade.wasm 708 false None
vault.wasm 8950 false None
forwarder.wasm 49004 false without message
proxy-test-second.wasm 2332 false without message
parent.wasm 1999 false None
child.wasm 3982 false without message
transfer-role-features.wasm 8605 false without message
first-contract.wasm 3450 false None
second-contract.wasm 1158 false None
forwarder-blind.wasm 14134 false without message
proxy-test-first.wasm 5707 false without message
mesh-node.wasm 16046 false without message
builtin-func-features.wasm 3828 false None
forwarder-legacy.wasm 33620 false without message
basic-features-small-int-bug.wasm 824 false None
basic-features.wasm 85947 false without message
basic-features-storage-bytes.wasm 541 false None
abi-tester.wasm 8607 true without message
abi-tester-ev.wasm 760 false None
rust-snippets-generator-test.wasm 4708 false None
formatted-message-features.wasm 3613 false without message
use-module-view.wasm 736 false None
use-module.wasm 32477 false without message
payable-features.wasm 6046 false None
exchange-features.wasm 1514 false None
forbidden-opcodes.wasm 842 false None
scenario-tester.wasm 1374 false None
std-contract.wasm 3469 true without message
big-float-features.wasm 6373 false without message
rust-testing-framework-tester.wasm 8552 false None
multi-contract-alt-impl.wasm 353 false None
multi-contract-features.wasm 681 false None
multi-contract-example-feature.wasm 680 false None
multi-contract-features-view.wasm 1113 false None
panic-message-features.wasm 13030 false with message
panic-message-std.wasm 16073 false with message
erc1155-user-mock.wasm 1229 false None
lottery-erc20.wasm 12886 false without message
erc721.wasm 2232 false None
crowdfunding-erc20.wasm 4909 false without message
erc1155-marketplace.wasm 10602 false without message
erc1155.wasm 12016 false without message
erc20.wasm 1887 false None
esdt-system-sc-mock.wasm 4556 false None
alloc-features.wasm 23260 false without message
alloc-mem-fail.wasm 17812 true without message
alloc-mem-leaking.wasm 23417 false without message
multiversx-wegld-swap-sc.wasm 4265 false None
multiversx-price-aggregator-sc.wasm 17904 false without message
ping-pong-egld.wasm 6397 false None
multisig-full.wasm 15128 false without message
multisig-view.wasm 5590 false None
multisig.wasm 13617 false without message
bonding-curve-contract.wasm 14067 false None
kitty-genetic-alg.wasm 3494 false without message
kitty-auction.wasm 9389 false without message
kitty-ownership.wasm 12965 false without message
check-pause.wasm 1260 false None
digital-cash.wasm 9736 false None
fractional-nfts.wasm 8302 false without message
adder.wasm 699 false None
order-book-pair.wasm 14099 false None
order-book-factory.wasm 3401 false None
empty.wasm 244 false None
esdt-transfer-with-fee.wasm 7505 false without message
nft-subscription.wasm 8725 false without message
proxy-pause.wasm 4165 false None
seed-nft-minter.wasm 14189 false without message
crowdfunding.wasm 3574 false None
nft-storage-prepay.wasm 2609 false None
crypto-bubbles.wasm 2561 false None
crypto-zombies.wasm 9282 false without message
nft-minter.wasm 9726 false without message
lottery-esdt.wasm 10580 false without message
factorial.wasm 579 false None
rewards-distribution.wasm 9445 false without message
token-release.wasm 6978 false without message

⚠️ Could not download the report for the base branch. Displaying only the report for the current branch. ⚠️

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the snippets interactor to allow an overridable gas price (instead of always using the network minimum), and refactors the forwarder-blind dex-interactor crate into clearer module/file names with a dedicated CLI/main entrypoint.

Changes:

  • Introduce gas_price on InteractorBase (defaulting to network_config.min_gas_price) and use it when building deploy/call transactions.
  • Refactor forwarder-blind dex-interactor into dex_interactor.rs + dex_interactor_cli.rs + dex_interactor_main.rs, and update Cargo.toml bin/lib paths.
  • Adjust dex-interactor to multiply the interactor gas price.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
framework/snippets/src/interactor/interactor_scenario/interactor_sc_deploy.rs Uses self.gas_price when building deploy transactions.
framework/snippets/src/interactor/interactor_scenario/interactor_sc_call.rs Uses self.gas_price when building call transactions.
framework/snippets/src/interactor/interactor_base.rs Adds gas_price field and initializes it from network config.
contracts/feature-tests/composability/forwarder-blind/dex-interactor/src/dex_interactor_main.rs New tokio main that runs the dex-interactor CLI.
contracts/feature-tests/composability/forwarder-blind/dex-interactor/src/dex_interactor_cli.rs New clap-based CLI definitions for dex-interactor commands.
contracts/feature-tests/composability/forwarder-blind/dex-interactor/src/dex_interactor.rs Module rename/refactor and sets a higher gas price in ContractInteract::new.
contracts/feature-tests/composability/forwarder-blind/dex-interactor/Cargo.toml Updates bin/lib entrypoints to the new file names.
Comments suppressed due to low confidence (2)

contracts/feature-tests/composability/forwarder-blind/dex-interactor/src/dex_interactor.rs:118

  • ContractInteract::new no longer applies config.use_chain_simulator(), so chain_type = simulator in config.toml will be ignored and chain-simulator-specific operations (funding wallets, generating blocks, etc.) won’t run. Re-introduce setting use_chain_simulator on the Interactor based on config.use_chain_simulator() before using the interactor.
    contracts/feature-tests/composability/forwarder-blind/dex-interactor/src/dex_interactor.rs:118
  • interactor.gas_price *= 25; introduces an unexplained magic multiplier. Consider making this a named constant and/or configurable via config.toml/CLI (and document why it’s needed), so it’s clear what gas price policy the interactor is using.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@andrei-marinica andrei-marinica changed the base branch from master to rc/v0.66 March 30, 2026 13:07
@andrei-marinica andrei-marinica marked this pull request as ready for review March 30, 2026 13:07
@andrei-marinica andrei-marinica merged commit a29dc7c into rc/v0.66 Mar 30, 2026
36 of 38 checks passed
@andrei-marinica andrei-marinica deleted the dex-interactor-3 branch March 30, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants