FIX(client): Registered AudioOutputBuffer as qRegisterMetaType

[jaggzh]

Checks

• [ x] My commits follow the commit guidelines

FIX(client): Registered the AudioOutputBuffer as qRegisterMetaType

Just a QT registration missing for the AudioOutputBuffer. Being only a single required registration I didn't make a separate function for it -- it's just in the constructor.

Fixes: #6569

[Hartmnt]

If you look at other occurrences of qRegisterMetaType https://github.com/search?q=repo%3Amumble-voip%2Fmumble%20qRegisterMetaType&type=code you can see that those mostly happen in the classes where the connections are being used. So I guess it would make sense to move your call of qRegisterMetaType in the constructor of ``AudioOutput.cpp` or something

Also please make sure your commit message follows our commit guidelines, otherwise the CI will not pass. The ChatGPT comment for the single line code change is also probably not needed.

[Hartmnt]

I assume you have checked if this still fixes the issue, right? Because you added the line to the AudioOutputRegistrar constructor instead of the AudioOutput constructor 😄
If both works functionally, I am more leaning towards putting it in the AudioOutput constructor.

The commit message you wrote in the description here on GitHub is fine, but you need to use it as your actual commit message. For that you will need to squash your commits and reword the message. See this for more information: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

[Hartmnt]

In addition to that you did not remove the changes you made to main.cpp. So please make sure your branch only contains relevant changes.

[Krzmbrzl]

Please also removr this changed line in your commit

[Hartmnt]

@Krzmbrzl Would you put this in the constructor of AudioOutputRegistrar or AudioOutput?

[Krzmbrzl]

I guess technically putting it into the AudioOutput constructor makes this execute multiple times (once for every created audio output Backend). Bot sure right now whether that would also be the case with the registrar.

On the other hand, this does no harm and having the call as close as possible to where it is needed makes semantic sense, I guess.

In the end I don't have a real preference 🤔

[Hartmnt]

Compiled and tested. Seems to fix the bug.

[Hartmnt]

@jaggzh Thank you very much for fixing this!