FIX(client): Save local volume adjustment when clicking slider bar #6574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ed988e6, clicking the slider bar of the local volume adjustment slider would correctly update the label and (temporarily) also update the user volume. However, since clicking on the slider bar does not fire a "sliderReleased" event, the value was not saved to the local volume adjustment database leading to it "randomly" resetting. This commit adds an additional signal/slot connection to save the value when the slider bar is clicked.
Hartmnt
added
client
ui
bug
Krzmbrzl
approved these changes
Sep 28, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Hartmnt
added a commit
that referenced
this pull request
Sep 28, 2024
…hen clicking slider bar" to 1.5.x (#6575)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ed988e6, clicking the slider bar of the local volume adjustment slider would correctly update the label and (temporarily) also update the user volume.
However, since clicking on the slider bar does not fire a "sliderReleased" event, the value was not saved to the local volume adjustment database leading to it "randomly" resetting.
This commit adds an additional signal/slot connection to save the value when the slider bar is clicked.