make secretId and versionId required fields #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just turning this proposed change into a PR, it makes a lot of sense to have k8s validate the required fields are present upfront, making it easier for users to debug issues.
Testing on my local k8s instance with a secret missing the
versionId
:Something to be aware of, though nobody should be doing this, if both
secretId
andversionId
are missing, kubernetes doesn't error, i.e. it'll accept the following file even with these updates: